Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better CF attributes to OMB parser #102

Merged
merged 6 commits into from
Sep 2, 2024

Conversation

jerabaul29
Copy link
Collaborator

No description provided.

trajan/readers/omb.py Outdated Show resolved Hide resolved
trajan/readers/omb.py Outdated Show resolved Hide resolved
@gauteh
Copy link
Member

gauteh commented Sep 2, 2024

@knutfrode
Copy link
Contributor

knutfrode commented Sep 2, 2024

There seem to be some mixture/confusion about standard_name and long_name here

standard_name is the most important attribute, and it has to be found in this table:
https://cfconventions.org/Data/cf-standard-names/current/build/cf-standard-name-table.html

long_name is less important, it is mainly to e.g. label axes, and is of human readable form, e.g. Significant wave height (and not sea_surface_wave_significant_height which would be the corresponding standard_name)

One will ideally have both standard_name and long_name, as they serve two different purposes (machine- and human readability, respectively), but if there exist no standard_name, one can use only long_name to at least make the variable human understandable, albeit not machine understandable.

@jerabaul29
Copy link
Collaborator Author

Ok, thanks for the explanation about standard_name vs long_name - I will fix this after lunch :) .

I am already using the table https://cfconventions.org/Data/cf-standard-names/current/build/cf-standard-name-table.html , but I can have one more look :) .

@knutfrode
Copy link
Contributor

Speaking about CF-convention, there is an upcoming workshop in Norrköping in two weeks:
https://cfconventions.org/Meetings/2024-Workshop.html#preliminary-agenda
I plan to follow some of the talks online.

@jerabaul29
Copy link
Collaborator Author

Does this look better? :) Anything that you think should be updated further? :)

Thank you for your patience and explanations about the different attributes etc - I have always been confused about all of this / struggled to find a simple and short explanation, I think this is much clearer now, hopefully I now understand this correctly ^^ :) .

trajan/readers/omb.py Outdated Show resolved Hide resolved
@knutfrode
Copy link
Contributor

I added a couple of comments, but this looks otherwise fine.
I can merge when you are ready.

@jerabaul29
Copy link
Collaborator Author

I think this should be ready to merge now :) . Thank you for the help, hope I got it right this time ^^ .

@knutfrode knutfrode merged commit dc5bfcb into OpenDrift:main Sep 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants