docker-machine: brings the docker image up to date #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As docker-machine is being deprecated by Docker, maintenance has been taken over by Gitlab. This commit bring several changes: - Update the documentation to reflect the new home of docker-machine -Update the Dockerfile to change docker-machine URI to the gitlab build - Update the Dockerfile to include by default the Scaleway and Hertzner drivers - Update the documentation of Scaleway and Hertzner to reflect changes made in Dockerfile
|
This is related to #88. |
|
Thanks @gromain 🙏 |
|
Would it be possible to trigger a rebuild of the clusterodm docker image? |
|
I realized we didn't have a GitHub action to update the clusterodm image (ups!) I've added it d2d25dd so the image should be updated soon. |
|
I was going to say that a GitHub action can be created! :-) Cool thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a lot of different things, all related to the deprecation of docker-machine.
First of, as docker-machine is being deprecated by Docker, maintenance has been taken over by Gitlab.
The first commit bring several changes:
The second commit is more of a usability point of view regarding the docker-compose.yml. There was previously no way to specify a
configuration.jsonfile to start docker compose with a autoscale configuration (even if in the documentation, the ability to use docker-compose is mentioned in the Autoscale section. This is now fixed.