Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding base for the client side Max&Min default values on create unit… #1364

Draft
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

mmehta2669
Copy link
Contributor

… issue

Description

This pr adds the max min default values to CreateUnitModalComponent.tsx as well as making minor changes units.tx and Unit.js to add the new parameters

Partly Addresses #1307

Type of change

(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

This pr only does the base client side, it still requires the server side connection as well as the prefer display changes to fully address the create unit part of the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant