Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added BG9 test case #1365

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

Kane1944
Copy link
Contributor

Description

Added BG9 test case in readingsBarGroupQuantity.js
Added file expected_bar_group_ri_15-20_mu_kWh_gu_MJ_st_-inf_et_inf_bd_1.csv

Joshua Leon - @Kane1944
Salvador Nunez - @SalvadorN323
Omar Rafiq - @omarraf

Partly addresses #962

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

N/A

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @Kane1944, @SalvadorN323 & @omarraf for their first contribution to OED. Review and testing found it works as expected. If it is converted from a draft to regular pull request then it should be accepted (just noticed it is draft so already did a review).

@Kane1944 Kane1944 marked this pull request as ready for review October 22, 2024 16:25
@Kane1944 Kane1944 requested a review from huss October 22, 2024 16:56
Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As previously noted, everything looks good. Congratulations to @Kane1944, @SalvadorN323 & @omarraf on their first accepted contribution.

@huss huss merged commit 7221862 into OpenEnergyDashboard:development Oct 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants