Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More updates to the Morison module #1578

Merged
merged 31 commits into from
Jun 5, 2023
Merged

More updates to the Morison module #1578

merged 31 commits into from
Jun 5, 2023

Conversation

luwang00
Copy link
Contributor

@luwang00 luwang00 commented May 17, 2023

r-tests will not pass. Need to update HydroDyn input files with the new buoyancy coefficient, $C_b$, entries and the hydrostatic load model switch, MHstLMod. (See PR #100 to r-test)

  • Hydrostatic load calculation is skipped with MHstLMod=0.
  • The existing hydrostatic load calculation is used with MHstLMod=1.
  • The new alternative hydrostatic load calculation is used with MHstLMod=2.

Feature or improvement description

  • Added buoyancy coefficient $C_b$ entries to the member-based hydrodynamic coefficients (Models 1, 2, and 3). When computing the hydrostatic load along a member and on the end plates, the scaled member radius (scaled by $\sqrt{C_b}$ ) is used. (Setting $C_b=0$ zeros the hydrostatic load on the member.)
  • Implemented an alternative approach for hydrostatic load calculation (MHstLMod=2) based on numerical integration along the length of the member. This approach should support arbitrary intersection between the instantaneous free surface (or still water level if no wave stretching) and the strip-theory member, including partially wetted end plates.
    • The original hydrostatic load calculation (MHstLMod=1) is more suitable for (nearly) vertical surface-piercing columns with the bottom end plate fully submerged and the top end plate dry at all times. Preferably the normal of the waterplane area is mostly aligned with the member axial direction. This method also works with fully submerged members.
    • The new alternative approach (MHstLMod=2) is more general but might be computationally more expensive.
  • Improved the robustness of the strip-theory hydrodynamic load calculation. The updated implementation should no longer assume the end node of a member is at the same level as or above the start node of the same member or that each member centerline crosses the free surface at most once. Neither assumption is guaranteed when WaveStMod>0 and WaveDisp=1.

Related issue, if one exists

Impacted areas of the software
HydroDyn => The modifications are confined to the Morison submodule of HydroDyn.

Release checklist:

…us with Cb

This change avoids physically inconsistent hydrostatic load.
…of member cross sections with the free surface
…lation

Also fixed the error handling of the new subroutines in Morison_CalcOutput
…e termination when the (sub)element bounds the waterplane
Need to use the instantaneous k vector.
@luwang00 luwang00 marked this pull request as draft May 17, 2023 04:25
@andrew-platt andrew-platt marked this pull request as ready for review June 5, 2023 20:02
@andrew-platt andrew-platt merged commit c745e10 into OpenFAST:dev Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants