Fix heap buffer overflow in nc_def_var of openfast-cpp #2443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
Fixes a heap-buffer-overflow error.
nc_def_var
size should take the value of the size of the dim array. The size ofptRefDataDims
is 1 so thenc_def_var
should take a 1. Feels like all of thesenc_def_var
should really be using*Dims.size()
But that would lead to a larger diff.Diagnosis
Related issue, if one exists
Impacted areas of the software
openfast-cpp