HD: Reimplement the initialization of low-pass-filtered potential-flow body positions for ExctnDisp=2 #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w body positions for ExctnDisp=2 without using mesh mapping This new implementation moves the initialization out of the glue-code and into HydroDyn_Init. This is more consistent with the OpenFAST modular structure and should help avoid some future problems with tight coupling. The use of SmllRotTrans is also replaced with EulerConstructZYX for large platform rotation.
andrew-platt
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is ready to be merged.
Feature or improvement description
This new implementation moves the initialization of the low-pass-filtered potential-flow body positions for
ExctnDisp=2out of the glue-code and intoHydroDyn_Init. The initial platform offset fromInit%OutData_ED%PlatformPosis copied toInit%InData_HD%PlatformPosfor HD initialization. This is more consistent with the OpenFAST modular structure and should help avoid some problems with tight coupling in the future.This updated implementation should fix several issues:
ED%yis no longer modified inFAST_InitializeAllto avoid problems with tight coupling.SmllRotTransis replaced withEulerConstructZYXto support large platform rotation.Related issue, if one exists
This PR is a reimplementation of PR #2341 to address the issues raised in PR #2421 based on the discussions with @bjonkman and @andrew-platt.
Impacted areas of the software
Glue code, HydroDyn
Test results, if applicable
No change to existing test results. All tests passed.