Add safety checks in AirfoilInfo for ill-defined airfoils #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calculating UA parameters, we need to check that there are sufficient points to compute the least-squares solution.
deslaughter
approved these changes
Oct 9, 2024
|
@bjonkman Thanks for getting this put together! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
When calculating UA parameters, we need to check that there are sufficient points to compute the least-squares solution.
This can be a problem when the airfoil doesn't have enough points between -20 and 20 degrees angle of attack and/or when the shape of the polar is somewhat unusual. This fix should get around the issues we have been seeing in some unusual airfoils, but a more robust fix will come later.
Related issue, if one exists
#2447
Impacted areas of the software
AeroDyn: AirfoilInfo and UnsteadyAero
Additional supporting information
Test results, if applicable
This does not appear to change results in the current regression tests. I don't think the UA parameters that failed in debug mode were used in the simulations (based on the UA models that are used).