-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade all ADv14 models to ADv15 (includes DBEMT) #18
Conversation
All models with DBEMT_MOD=1 still need to have valid tau1_const calculated
@ghaymanNREL what is the status on this? |
@andrew-platt , I have taken this as far as I am able. Any additional modifications will need to come from the NREL OpenFAST team. |
@ghaymanNREL thanks! We'll start a PR on the main OpenFAST branch with these updates (after OpenFAST/openfast#373 and OpenFAST/openfast#447). Then once fast.FARM is merged (PR not ready yet), we'll do a full deprecation of AD14. |
Why did this PR get closed before it got merged in? I'd like this PR to get merged in soon. After talking with @andrew-platt, my understanding is that this PR would be merged in soon. |
This pull request was automatically closed when I deleted the |
FWIW: In OpenFAST/openfast#538 I added a |
This pull request updates all r-test models which used AeroDyn version 14 to now use AeroDyn version 15.
The following models still require work to determine the appropriate tau1_const parameter in the ADv15 input file:
AWT_YFree_WTurb
AWT_YFix_WSt
WP_VSP_WTurb_PitchFail
WP_VSP_WTurb
SWRT_YFree_VS_WTurb
Per @jjonkman :
"I would recommend users use DBEMT_Mod = 1 for most simulations (e.g., turbulence). I see DBEMT_Mod = 2 only useful for cases where the mean wind speed changes a lot over time, e.g. step-wind cases. With DBEMT_Mod = 1, I would set tau1_const = 1.1/(1-1.3*min(abar,0.5)) * R/Vbar_hub, which is the standard constant [where] abar is the rotor-averaged axial induction. Vbar_hub is the time-averaged wind speed at hub height. To calculate abar, you have to post-process an equivalent simulation using steady wind at the mean wind speed of interest."
All of the revised test cases vary from their baselines (some more than others).
For example (sample plots only):
WP_VSP_ECD:
AWT_YFree_WTurb:
AWT_YFix_WSt:
WP_VSP_WTurb_PitchFail:
WP_VSP_WTurb:
AOC_WSt:
5MW_ITIBarge_DLL_WTurb_WavesIrr:
UAE_Dnwind_YRamp_WSt:
SWRT_YFree_VS_WTurb:
SWRT_YFree_VS_EDC01: