Worker: Log improvements and WORKER_MAX_SOCKET_TIMEOUT_SECONDS #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephjclark
changed the title
|
@taylordowns2000 The websocket timeout should be working on this branch Image should be built for 1.5.5 I don't have any automated or manual tests on the actual timeout. I know the value is being passed in to the Pheonix socket, I've just not verified it's working. It's a little tricky to setup a slow response in the mock - although it should be possible of course. If you can test manually on the image I'm happy to release. I'll probably spend an hour on it in the morning and see if I can crack it quickly. |
|
Oh bottoms, it's all failed :( Ok, I'll fix in the morning |
|
Ok, should be sorted now 👍 |
|
Test added so I'm happy that this is working as expected |
taylordowns2000
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds WORKER_MAX_SOCKET_TIMEOUT_SECONDS variable to control socket timeouts.
A few other tiny logging tweaks here.