Worker: better handling of backoff when at capacity #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@taylordowns2000 worker 1.6.7 is ready to go with a better backoff strategy. Give it a run on staging for me when you're ready please! |
|
@taylordowns2000 can I merge this? I take it staging didn't blow up [as a result of this change]? |
taylordowns2000
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the worker is at capacity, it will now terminate the workloop and stop trying to claim.
Once the server is back to capacity, it'll resume the workloop, resetting the backoff to the initial value.
Logging has also been improved.
I've tested this manually - I'm trying to think of a decent automated test. It is a little hard to quanty the backoffs..
#786