-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple adaptors in the compiler #797
Merged
josephjclark
merged 14 commits into
release/collections
from
multi-adaptors-compiler-imports
Oct 22, 2024
Merged
Support multiple adaptors in the compiler #797
josephjclark
merged 14 commits into
release/collections
from
multi-adaptors-compiler-imports
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ah ok - we need to add support for multiple adaptors in the engine as part of this PR, because the engine's call into the compiler is now wrong |
The size of the diff here is really escalating! The work is fairly trivial but far reaching and requires close thought. Hopefully get it wrapped on Monday |
Phew! I think this is done. Changed my strategy on how to do this several times 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
This PR enables the compiler to generate import statements for two adaptors.
This basically just means turning the
adaptor
option (which days which adaptor to use) intoadaptors
and making it an array. This turns out to have a huge ripple effect in the typings but it's sorted now: the "entry points" tend to ensure thatadaptors
is an array, massing the original input in to the right format.One issue which arises out of this work is the possibility of conflict. If you import
http
andfhir
, for example, do we importfn
fromhttp
orfhir
? Fortunately with collections we don't really need to address this issue. But if somehow it ever does come up, it'll result in compiled javascript code being invalid. So we can deal with this later.This is part of #777
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy