Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple adaptors in the compiler #797

Merged
merged 14 commits into from
Oct 22, 2024

Conversation

josephjclark
Copy link
Collaborator

@josephjclark josephjclark commented Oct 18, 2024

Short Description

This PR enables the compiler to generate import statements for two adaptors.

This basically just means turning the adaptor option (which days which adaptor to use) into adaptors and making it an array. This turns out to have a huge ripple effect in the typings but it's sorted now: the "entry points" tend to ensure that adaptors is an array, massing the original input in to the right format.

One issue which arises out of this work is the possibility of conflict. If you import http and fhir, for example, do we import fn from http or fhir? Fortunately with collections we don't really need to address this issue. But if somehow it ever does come up, it'll result in compiled javascript code being invalid. So we can deal with this later.

This is part of #777

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

@josephjclark
Copy link
Collaborator Author

Ah ok - we need to add support for multiple adaptors in the engine as part of this PR, because the engine's call into the compiler is now wrong

@josephjclark
Copy link
Collaborator Author

The size of the diff here is really escalating! The work is fairly trivial but far reaching and requires close thought. Hopefully get it wrapped on Monday

@josephjclark
Copy link
Collaborator Author

Phew! I think this is done. Changed my strategy on how to do this several times 😊

@josephjclark josephjclark merged commit 9186fa8 into release/collections Oct 22, 2024
6 checks passed
@josephjclark josephjclark deleted the multi-adaptors-compiler-imports branch October 22, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant