Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename from arsenic to cinnabar #63

Merged
merged 1 commit into from
Aug 21, 2022
Merged

rename from arsenic to cinnabar #63

merged 1 commit into from
Aug 21, 2022

Conversation

richardjgowers
Copy link
Contributor

Description

Provide a brief description of the PR's purpose here.

Todos

Notable points that this PR has either accomplished or will accomplish.

  • TODO 1

Questions

  • Question1

Status

  • Ready to go

@IAlibay
Copy link
Member

IAlibay commented Aug 21, 2022

codecov might take some time to get its act together unfortunately

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All synched on the codecov end, lgtm!

@codecov
Copy link

codecov bot commented Aug 21, 2022

Codecov Report

Merging #63 (f5fa7ba) into main (0870e93) will not change coverage.
The diff coverage is 100.00%.

@IAlibay IAlibay merged commit 76130d1 into main Aug 21, 2022
@IAlibay IAlibay deleted the rename_to_cinnabar branch August 21, 2022 14:20
@jchodera
Copy link
Contributor

What's the plan regarding deprecation of the old conda package?

Would it make sense to release one more arsenic release to issue a warning on import that the package name has changed, and users should change their dependencies and imports to cinnibar to stay up to date with the latest releases? Or is the goal to completely change the API so it would not make sense to do so?

@IAlibay
Copy link
Member

IAlibay commented Aug 22, 2022

Ah yeah that's a great point @jchodera (sorry I think we got a bit trigger happy so we could get naming up for some upcoming talks).

I suspect we'll be looking at a pretty big API change (@mikemhenry can weigh in here), my 2 cent would be to make a clean break between packages. It would be nice to make a final 0.2.2 arsenic release based on current HEAD-1 in the git history though?

@richardjgowers
Copy link
Contributor Author

I don't think we've made any changes since Mike did v0.2.1 a while ago.

@jchodera
Copy link
Contributor

Further releases may not be required, but can you at least create a long-term maintenance branch from the 0.2.1 release version in case there's a critical bugfix that needs to be backported, or someone needs to look up the code for a deployed or historical release of arsenic?

@jchodera
Copy link
Contributor

@mikemhenry : What's the best practice about renaming the historical releases to arsenic-x.y.z so it's clear which versions had the old package name?

@IAlibay
Copy link
Member

IAlibay commented Aug 22, 2022

can you at least create a long-term maintenance branch from the 0.2.1 release version in case there's a critical bugfix that needs to be backported

With previous experience in trying to do this in the past for MDA, taking on that maintenance burden (even for a branch with timed obsolescence as was the case for MDA) is a non-insignificant cost.

I understand why this is being asked, but who is meant to take charge of LTS for the historical arsenic code? It's not immediately clear to me that OpenFE has the bandwidth for things like keeping CI alive, making sure packaging still works etc...

@richardjgowers
Copy link
Contributor Author

If we're interested in keeping arsenic around for posterity, we can (re)create a repo that has the last commit of v0.2.1, and cinnabar essentially becomes a fork of arsenic from that point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants