-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename from arsenic to cinnabar #63
Conversation
codecov might take some time to get its act together unfortunately |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All synched on the codecov end, lgtm!
What's the plan regarding deprecation of the old conda package? Would it make sense to release one more arsenic release to issue a warning on import that the package name has changed, and users should change their dependencies and imports to |
Ah yeah that's a great point @jchodera (sorry I think we got a bit trigger happy so we could get naming up for some upcoming talks). I suspect we'll be looking at a pretty big API change (@mikemhenry can weigh in here), my 2 cent would be to make a clean break between packages. It would be nice to make a final 0.2.2 arsenic release based on current HEAD-1 in the git history though? |
I don't think we've made any changes since Mike did v0.2.1 a while ago. |
Further releases may not be required, but can you at least create a long-term maintenance branch from the 0.2.1 release version in case there's a critical bugfix that needs to be backported, or someone needs to look up the code for a deployed or historical release of arsenic? |
@mikemhenry : What's the best practice about renaming the historical releases to |
With previous experience in trying to do this in the past for MDA, taking on that maintenance burden (even for a branch with timed obsolescence as was the case for MDA) is a non-insignificant cost. I understand why this is being asked, but who is meant to take charge of LTS for the historical arsenic code? It's not immediately clear to me that OpenFE has the bandwidth for things like keeping CI alive, making sure packaging still works etc... |
If we're interested in keeping arsenic around for posterity, we can (re)create a repo that has the last commit of v0.2.1, and cinnabar essentially becomes a fork of arsenic from that point. |
Description
Provide a brief description of the PR's purpose here.
Todos
Notable points that this PR has either accomplished or will accomplish.
Questions
Status