don't codecov on cron builds #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IAlibay
reviewed
Apr 10, 2023
.github/workflows/ci.yml
Outdated
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| files: ./coverage.xml | ||
| fail_ci_if_error: true # optional (default = false) | ||
| fail_ci_if_error: false |
There was a problem hiding this comment.
you're always best to fail here, that way you know to restart the build to get coverage information, otherwise you'll have misleading info at best
There was a problem hiding this comment.
codecov is flakey and advisory, I'd rather it not fail a PR
There was a problem hiding this comment.
it really doesn't fail that much tbh - I've seen conda resolution errors more often
Plus on runners of this length, it's no big deal to just restart it or just check that CI ran and then ignore the fail
There was a problem hiding this comment.
it is a lot worse if you ask someone to add test coverage when it's already covered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide a brief description of the PR's purpose here.
Todos
Notable points that this PR has either accomplished or will accomplish.
Questions
Status