Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use qt6 for mac instead qt5 #442

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Use qt6 for mac instead qt5 #442

merged 2 commits into from
Sep 13, 2024

Conversation

tbaudier
Copy link
Contributor

No description provided.

@BishopWolf
Copy link

You shall move completely to QT6 in all systems. QT5 is mostly in maintenance status and will die eventually. Moreover, QT6 solves a lot of issues, specifically for PyQt.

@nkrah
Copy link
Collaborator

nkrah commented Aug 28, 2024

As a side note: I have been experiencing compile issues on my Mac with Qt5 (installed via brew) and geant4 recently. Ended up compiling geant4 without Qt for now. In any case a good idea to move to Qt6

@BishopWolf
Copy link

Linked issue #338

Change cache to compile G4 with qt6
Qt6 is not installed in the same directory than Qt5 on macOS

Try to add libqcocoa into the wheel. cibuildwheel could not do it so I compile and delocate the wheel by myself
@BishopWolf
Copy link

BishopWolf commented Sep 5, 2024

"[Remove macos14 because python does not work now]"

This is because python 3.8 doesn't work on mac14, you shall drop python 3.8 support for that. Most systems (including debian 11 Bullseye) are on minimum python 3.9 anyway.

@BishopWolf
Copy link

BishopWolf commented Sep 5, 2024

This error is not related to python. There is a missing key in the dictionary pulled from C++.

There is also this error that I think is more relavant

WARNING: Requirement 'dist/opengate_core-*-cp310-cp310-manylinux*_x86_64.whl' looks like a filename, but the file does not exist
ERROR: Invalid requirement: 'opengate-core==*': Expected end or semicolon (after name and no valid version specifier)
    opengate-core==*

@tbaudier
Copy link
Contributor Author

tbaudier commented Sep 5, 2024

"[Remove macos14 because python does not work now]"

This is because python 3.8 doesn't work on mac14, you shall drop python 3.8 support for that. Most systems (including debian 11 Bullseye) are on minimum python 3.9 anyway.

Here, the error was due to that problem: actions/setup-python#825
BTW, 3.8 will be drop

@BishopWolf
Copy link

Beware of this warning (it should be an error):

/Users/runner/miniconda3/envs/opengate_core/lib/python3.10/site-packages/setuptools/command/build_py.py:215: _Warning: Package 'opengate_core.plugins' is absent from the `packages` configuration.

@tbaudier
Copy link
Contributor Author

tbaudier commented Sep 6, 2024

Beware of this warning (it should be an error):

/Users/runner/miniconda3/envs/opengate_core/lib/python3.10/site-packages/setuptools/command/build_py.py:215: _Warning: Package 'opengate_core.plugins' is absent from the `packages` configuration.

'opengate_core.plugins' contains the qt librairies needed by QtCore to display. You can find libqcocoa for exemple. No python scripts are available in that folder so I'm not sure the folder should be in the packages configuration.

I need to create that folder because delocate could not find theses librairies by itself

@BishopWolf
Copy link

BishopWolf commented Sep 9, 2024

I see you are testing brew instead of conda, just a hint: you can't have mixed packages with BOTH installers. Therefore, to use brew you must drop conda completely (for all packages) watch this line

- uses: conda-incubator/setup-miniconda@v3

Install qt6 with brew instead of conda
With conda, during ccmake of geant4, I have to set QT_HOST_PATH and QT_HOST_PATH_CMAKE_DIR. Even with that I still have problem due to a cross-compile of qt6

workaround for delocate https://github.c/neuronsimulator/nrn/pull/1897

Update doc
@tbaudier tbaudier merged commit fa33156 into master Sep 13, 2024
28 checks passed
@tbaudier tbaudier deleted the qt6 branch September 13, 2024 13:25
@tbaudier
Copy link
Contributor Author

I see you are testing brew instead of conda, just a hint: you can't have mixed packages with BOTH installers. Therefore, to use brew you must drop conda completely (for all packages) watch this line

- uses: conda-incubator/setup-miniconda@v3

conda is just used to install qt6 c++ librairies. I do not use conda to install python packages. For macOS, I use Github Actions for intel Mac and Cirrus for M1. On M1 brew do not succeed to install qt6 correctly, this is why I used conda.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants