Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare PR #478 OptiGAN for merge #499

Open
wants to merge 41 commits into
base: master
Choose a base branch
from
Open

Prepare PR #478 OptiGAN for merge #499

wants to merge 41 commits into from
+692 −2

Conversation

nkrah
Copy link
Collaborator

@nkrah nkrah commented Oct 19, 2024

Review and adapt the code to match the GATE 10 architecture.

In particular,

  • simplify handling of output directories.
  • Let the user provide a phase space actor as input and pick up as much information from there.
  • alternatively, allow for stand-alone operation based on root_file_path

@guneet19
Added Support Functions for OptiGAN
54b147d
@guneet19
Created New Test Case for OptiGAN
7e5bb1d
@guneet19
Verifier for OptiganHelpers Class
5850ba6
@guneet19
Added code to read the output path from testfile
6816a22
@guneet19
Added use_optigan flag
4a276ae
@guneet19
Added modules to print optigan input data
cb9928c
@guneet19
Added code to save input csv files
c4ddffa
@guneet19
Added comments for optigan modules
3810745
@guneet19
test case including use_optigan
06e2cf8
@guneet19
Added physics manager check
531feab
@guneet19
fixed the segmentation fault
953e21f
@guneet19
added dependency version info
d3c7462
@guneet19
Merge branch 'master' into ucdavis-Create-Dataset
6cd5016
@guneet19
Merge branch 'master' into ucdavis-Create-Dataset
ea49e43
@guneet19
Merge branch 'master' into ucdavis-Create-Dataset
6f62cc6
@guneet19
Changed code to read data with updated phase space actor
24aa64b
@guneet19
Refactored OptiGAN code
3734f09
@guneet19
Fixed OptiGAN method call
0d22015
@guneet19
Created different methods for output and plotting
531d51f
@guneet19
Added optical to init
bb79304
@guneet19
Created OptiGAN files in contrib
7aa3373
@guneet19
Ignore input and output folders in contrib/optical
efdc0e2
@guneet19
Added Comments
9a6a31a
@guneet19
Revert engines.py to version from master branch
a60882a
@guneet19
Remove optiganhelpers.py from tracked files
999d1a4
@guneet19
Revert managers.py to version from master branch
5876d74
@guneet19
Remove opengate/tests/src/test074_optigan_root_output_no_conversion.py
9026fc0
@guneet19
Removed opengate/tests/src/test074_optigan_phsp_and_kill_actor.py
f9197f9
@guneet19
Removed opengate/tests/src/test075_testing_use_optigan_feature.py
a81e2bb
@guneet19
Merge branch 'master' into ucdavis-Create-Dataset
9944ebb
@nkrah
Copy link
Collaborator Author

nkrah commented Oct 19, 2024

I will check for remaining commented code to be removed before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkrah @guneet19