Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addition of tictac toe game on quark #125

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

addition of tictac toe game on quark #125

wants to merge 3 commits into from

Conversation

pratiksinghchauhan
Copy link
Member

Fixes issue:

Changes:
Added a integration of tictactoe game to Quark under more apps menu.

@AdiChat
Copy link
Member

AdiChat commented Apr 15, 2018

Nice work 👍

For tic tac toe, the user might want to play with the Computer. You will find examples on the web using which you can adapt accordingly. Doing this will enable the user to enjoy his/ her time alone as well.

Additionally, you may move the game into a new dropdown named "Games". You may assign a complete page for a game though the modal looks good as well.

Kindly take a look into it and make corresponding changes. 👍

@pratiksinghchauhan
Copy link
Member Author

sure I will do it ASAP

@AdiChat
Copy link
Member

AdiChat commented Apr 17, 2018

Great work 👍

A level (say "Master") must be selected by default and the option to select the level should appear on the right side of the game area. This enables the user to start the game right away.

It will be great if an option for the computer to start the game is available. This will improve the interactivity of the user. An option to restart the game must be available. Also, include instructions to play the game in a modal on the game page.

Additionally, keep the css and js files for this game inside the folder structure css/games/tictactoe and js/games/tictactoe respectively.

Kindly take a look into this and make corresponding changes 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants