Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory indexing for creating search database #95

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AasthaGupta
Copy link
Contributor

Fixes issue: #70

Changes:

This will ease the process of updating search entries because now we
don't have to maintain a hard-coded database and a simple update in the
directory will be enough.

@AasthaGupta
Copy link
Contributor Author

@AdiChat Please review it and let me know if any changes are required.

@AdiChat
Copy link
Member

AdiChat commented Mar 11, 2018

Generating metadata obj every time Quark is loaded may not be efficient.

Instead, you can create a script to generate the metadata (as you did) from a settings page setting.html. Users may trigger this manually. Also, moving the metadata from popup.js to a separate file will be a good design choice.

Kindly take a look into this and make appropriate changes. 👍

Fixes OpenGenus#70
This will ease the process of updating search entries because now we
don't have to maintain a hard-coded database and a simple update in the
directory will be enough.
@AasthaGupta
Copy link
Contributor Author

@AdiChat I have made the required changes. Please review it and let me know if any more changes are required.

@AasthaGupta
Copy link
Contributor Author

@AdiChat any update on this?

@AasthaGupta
Copy link
Contributor Author

@AdiChat I have updated the pull request.

  • Now directory indexing will be done only once and stored in the local storage.Moreover, it will done in the background, so the extension can start without any delay.
  • Added the option to Refresh under settings, to refresh the data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants