Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support most common usecase for mounting configmaps as files #83

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

whereismyjetpack
Copy link
Contributor

@whereismyjetpack whereismyjetpack commented Sep 9, 2024

Externally managed configmaps can mount their keys as files

name: "{{ .name }}"
{{- if .subPath }}
subPath: "{{ .subPath }}"
{{- end -}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to support the readOnly flag... probably default to true. Orca says its a High security risk to not use it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set the readOnly bit to true in most cases. we can override as a key if we need to

@whereismyjetpack whereismyjetpack merged commit f5e162d into master Sep 9, 2024
1 check passed
@whereismyjetpack whereismyjetpack deleted the configmap-volume branch September 9, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants