Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Threads/issues/251 #252

Merged
merged 4 commits into from
May 13, 2024
Merged

Threads/issues/251 #252

merged 4 commits into from
May 13, 2024

Conversation

peter-lawrey
Copy link
Member

No description provided.

@peter-lawrey peter-lawrey requested a review from JerryShea May 9, 2024 08:42
tgd
tgd requested changes May 10, 2024
View reviewed changes
Copy link
Contributor

@tgd tgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Peter - mostly looks good - my main feedback is to flag explicitly in the commit and issue about the scope of the change - there are a few fixes here beyond improving the toString.

src/main/java/net/openhft/chronicle/threads/BusyTimedPauser.java Show resolved Hide resolved
src/main/java/net/openhft/chronicle/threads/LongPauser.java Outdated Show resolved Hide resolved
src/main/java/net/openhft/chronicle/threads/LongPauser.java Show resolved Hide resolved
src/main/java/net/openhft/chronicle/threads/Pauser.java Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
23 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.5% Coverage on New Code
6.7% Duplication on New Code

See analysis details on SonarCloud

@peter-lawrey peter-lawrey merged commit e19ba89 into develop May 13, 2024
9 of 10 checks passed
@peter-lawrey peter-lawrey deleted the threads/issues/251 branch May 13, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JerryShea JerryShea JerryShea left review comments

@RobAustin RobAustin RobAustin approved these changes

@tgd tgd tgd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peter-lawrey @tgd @RobAustin @JerryShea