Format dates according to user locales, not language #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
commented
Jan 5, 2024
| @@ -51,7 +51,7 @@ export function validationFormatting() { | |||
| if (edtfFromOSM) { | |||
| let label; | |||
| try { | |||
| label = edtf.default(edtfFromOSM).format(localizer.languageCode()); | |||
| label = edtf.default(edtfFromOSM).format(localizer.localeCode()); | |||
There was a problem hiding this comment.
Upon code inspection, edtf.js seems to expect a single locale string here, not an array of them like the built-in functions.
erictheise
approved these changes
Feb 20, 2024
Open
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the current language code with the array of preferred locale codes in the date fields and date-related validation rules added in #185, #187, and #188.
Fixes OpenHistoricalMap/issues#670.