Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pnpm-lock.yaml desynchronized w/ package.json #147

Closed
DerekNonGeneric opened this issue Nov 20, 2022 · 4 comments · Fixed by #277
Closed

pnpm-lock.yaml desynchronized w/ package.json #147

DerekNonGeneric opened this issue Nov 20, 2022 · 4 comments · Fixed by #277
Labels
bug Something isn't working build dependencies deps-dev infrastructure tools Issues and PRs related to the tools directory

Comments

@DerekNonGeneric
Copy link
Member

DerekNonGeneric commented Nov 20, 2022 •
edited
Loading

Apparently pnpm's lockfile never got updated as the package-lock.json normally would w/ PRs made by @dependabot & @renovatebot. They have now become desynchronized w/ only the pinned deps in the package.json being accurate.
@DerekNonGeneric DerekNonGeneric added bug Something isn't working tools Issues and PRs related to the tools directory dependencies build deps-dev infrastructure needs-investigation labels Nov 20, 2022
@DerekNonGeneric
Copy link
Member Author

I removed all lockfiles associated w/ npm. I am also considering removing the one associated w/ Ruby.

@DerekNonGeneric
Copy link
Member Author

We need to start having these PRs automatically approved and merged if they pass CI. I am not yet sure how that would be accomplished, but it would certainly be much load off maintaining deps.

/cc @smorimoto as has contributed to https://github.com/fastify/github-action-merge-dependabot

@DerekNonGeneric
Copy link
Member Author

Okay, so no response from @smorimoto; i am going to proceed w/ getting that implemented unless anyone has any objections.

@DerekNonGeneric
Copy link
Member Author

My only concern(s) stem from potentially missing reqs outlined btwx myself and @yuvilio via email some months ago:

AFAICT, we will need to be doing some major re-hauling…

In the meantime, i will simply try to get things a bit more automated, but noting that we would need to re-evaluate this strategy in the future.

@DerekNonGeneric DerekNonGeneric mentioned this issue Dec 10, 2022
Open
DerekNonGeneric added a commit that referenced this issue Feb 24, 2023
@DerekNonGeneric
dep: create pnpm-lock.yaml
a3153a6 
Fixes: #147
@DerekNonGeneric DerekNonGeneric mentioned this issue Feb 24, 2023
Merged
9 tasks
DerekNonGeneric added a commit that referenced this issue Feb 24, 2023
@DerekNonGeneric
dep: re-create up-to-date pnpm-lock.yaml file
f0835cb 
PR-URL: GH-277
Fixes: GH-147
Signed-off-by: Derek Lewis <dereknongeneric@open.inf.is>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working build dependencies deps-dev infrastructure tools Issues and PRs related to the tools directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dep: create pnpm-lock.yaml OpenINF/.github
1 participant
@DerekNonGeneric