-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): ensure “Gallium” runtime & toolchain #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Begin specifying the Last Known Good Release of Node.js toolchain, which is the 1ˢᵗ version of the “Gallium” LTS release line. Refs: nodejs/node#40536 (review) > This release marks the transition of Node.js 16.x into Long Term > Support (LTS) with the codename “Gallium”. The 16.x release line > now moves into “Active LTS” and will remain so until October 2022. > After that time, it will move into “Maintenance” until end-of-life > in April 2024. Refs: https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V16.md#16.13.0 * Begin specifying that we would like to use globally-installed npm. > While `npm` is a valid option in the “packageManager” property, the > lack of shim will cause the global npm to be used. Refs: https://nodejs.org/docs/v16.13.0/api/corepack.html#corepack_how_does_corepack_interact_with_npm > If the value corresponds to a supported package manager, Corepack > will make sure that all calls to the relevant binaries are run > against the requested version, downloading it on demand if needed, > and aborting if it cannot be successfully retrieved. Refs: https://nodejs.org/docs/v16.13.0/api/corepack.html#configuring-a-package Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
DerekNonGeneric
commented
Aug 23, 2022
Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
I will have to rebase this commit because nodejs/Release#752 states that the EOL date was changed to be sooner-than-anticipated. |
DerekNonGeneric
added a commit
to DerekNonGeneric/openinf-util-md-table
that referenced
this pull request
Aug 25, 2022
> If you want to prevent contributors of your project from adding new > incompatible dependencies, use `node-version` and `engine-strict` in > a `.npmrc` file at the root of the project. Refs: https://pnpm.io/npmrc#node-version This way, even if someone is using Node.js v18 runtime & toolchain, they will not be able to install a new dependency that doesn't support our Node.js v16.13.0 (“Gallium” runtime & toolchain). Refs: OpenINF#64
DerekNonGeneric
added a commit
that referenced
this pull request
Aug 27, 2022
* feat(infra): inform pnpm users “Gallium” runtime > If you want to prevent contributors of your project from adding new > incompatible dependencies, use `node-version` and `engine-strict` in > a `.npmrc` file at the root of the project. Refs: https://pnpm.io/npmrc#node-version This way, even if someone is using Node.js v18 runtime & toolchain, they will not be able to install a new dependency that doesn't support our Node.js v16.13.0 (“Gallium” runtime & toolchain). Refs: #64 * build(deps-dev): set min “Gallium” LTS in `/.npmrc` Refs: https://docs.npmjs.com/cli/v8/using-npm/config#engine-strict Refs: https://docs.npmjs.com/cli/v8/using-npm/config#node-version Refs: https://docs.npmjs.com/cli/v8/using-npm/config#npm-version Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Begin specifying the Last Known Good Release of Node.js toolchain
LKGR of Node.js toolchain is 1ˢᵗ release of “Gallium” LTS (v16.13.0).
Refs: v16.13.0 release proposal nodejs/node#40536 (review)
Days until “Gallium” goes into “Maintenance” (October 2022): 8 weeks from now1
Days until “Gallium” goes EOL (April 2024): 86 weeks from now2
Refs: https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V16.md#16.13.0
Begin specifying that we would like to use globally-installed npm
Refs: https://nodejs.org/docs/v16.13.0/api/corepack.html#corepack_how_does_corepack_interact_with_npm
Refs: https://nodejs.org/docs/v16.13.0/api/corepack.html#configuring-a-package
Signed-off-by: Derek Lewis DerekNonGeneric@inf.is
/cc @septs
Footnotes
https://www.wolframalpha.com/input?i2d=true&i=third+Tuesday+in+October+of+year+2022 ↩
https://www.wolframalpha.com/input?i2d=true&i=third+Tuesday+in+April+of+year+2024 ↩