Package: logcat-openipc #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding the Android logging facility used by Ingenic IMP libraries
gtxaspec
requested review from
widgetii,
dimerr and
flyrouter
as code owners
|
Thanks for sending PR but I have a question - why don't you make it so that the source code of the program is taken from your repository, as it is done in other packages. It would be more correct and efficient. We try to add program code directly into Firmware repo only if it contains not more than a dozen files. The link can go either to your personal repository on GitHub or you can make a transfer to the OpenIPC organization of any of your repos while retaining the rights of the main developer. Please think about it. So to add a new package you only need two new files, the first in your PS and minimal configuration edits. Thanks. |
|
@flyrouter yes, I agree. Stand by for PR edit. |
|
@flyrouter changes completed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logcat-openipc: added userspace programs (logcat, logwrapper) for reading the Android logging facility used by Ingenic IMP libraries