Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introducing the RFC process #7

Merged
merged 2 commits into from
Dec 21, 2023
Merged

feat: introducing the RFC process #7

merged 2 commits into from
Dec 21, 2023

Conversation

ddneilson
Copy link
Contributor

This adds a first go at an RFC process for Open Job Description. The goal is to have a process defined with the expectation that we will iterate on it as we learn from it.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This adds a first go at an RFC process for Open Job Description. The goal
is to have a process defined with the expectation that we will iterate on it
as we learn from it.

Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com>
rfcs/README.md Outdated Show resolved Hide resolved
rfcs/README.md Show resolved Hide resolved
shidarin
shidarin previously approved these changes Dec 21, 2023
Copy link
Contributor

@shidarin shidarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits. Some wording changes requested.

.github/ISSUE_TEMPLATE/rfc.md Show resolved Hide resolved
* **Pull Request**: (Add the URL to the pull request here.)
* **Discussion Thread(s)**:
* (If there are discussion forum threads where this RFC has been discussed, then
add URLs to those here. Otherwise, remove this bullet point.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please

your feature would enable for users. How common are those use cases: Are they specific
to one company's way of working, or more generally adopted?

Avoid rationales like "this is available like this in system X" since that rationale may not
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially patronizing. Recommend removing the first 2 sentences and keep the rest- it conveys the message fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair. I'll modify this paragraph.


What are the specific changes that are being proposed?

Write this in a form similar to the official formal specification documents as though
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write

rfcs/README.md Outdated

RFCs can be created by anyone in the community. If you have an idea, a kernel of an idea, or a
problem to solve, and you think that an addition or a modification of the Open Job Description
specification is the way to go then we encourage you to engage in this process.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove ", and you think... is the way to go"

They think it's the way to go, or else they wouldn't be here :)

rfcs/README.md Outdated

Before you start along the path of proposing your idea as an RFC, please take some time
to search through our [issues tracker] and [discussion forum] for similar or compatible
proposals. It is possible that your idea has previously been proposed or that it might fit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proposed, or it

rfcs/README.md Outdated

### 2. Post in GitHub Discussions

As an informal starting point, we suggest that you use our discussion forums to have
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you try our

rfcs/README.md Outdated
the hub for conversations, community signal (+1s) and the issue number is used
as the unique identifier of this RFC.

> Before creating a tracking issue, please search for similar or related ideas
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean to indent this?

rfcs/README.md Outdated

Once you have an initial version of your RFC document (it is completely fine to
submit an unfinished RFC to get initial feedback), submit it as a pull request
against this repository and start collecting feedback.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace 'and' with 'to'

rfcs/README.md Outdated

The team will contact you through your RFCs tracking issue when it is time to include
the proposal in the current draft specification. When that happens, we ask that you
prepare pull requests to that modify the draft specification, user documentation, and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: prepare pull requests to that modify

Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com>
Copy link
Contributor

@shidarin shidarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll get a merge conflict on wiki/Home.md

@ddneilson ddneilson merged commit f1d1373 into mainline Dec 21, 2023
2 checks passed
@ddneilson ddneilson deleted the ddneilson/rfcs branch December 21, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants