Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release cleanup #530

Merged
merged 7 commits into from
Jan 18, 2016
Merged

Release cleanup #530

merged 7 commits into from
Jan 18, 2016

Conversation

xlz
Copy link
Member

@xlz xlz commented Jan 7, 2016

  • Re-organize docs and misc files to libfreenect model
  • Add versioning (libfreenect2.so -> libfreenect2.so.0.1.0)
  • Fix static analysis warnings

The libfreenect2.so.0.1.0 change has some potential effect on downstream iai_kinect2 etc. I'll test these together.

@xlz
docs: Organize docs and doxygen files together
368864c
@xlz
docs: Remove GPL Doxyfile comments
cbb8c85 
These comments come from Doxygen code and are licensed under GPL
only. To avoid incompatibility with Apache license, remove them.
@xlz
Organize miscellaneous platform specific files
5765716
@xlz
cmake: Add release versioning variables
ae7867f 
Also use shared library versioning .so.x.y.z

To create a new release, edit the main CMakeLists.txt and change
PROJECT_VER_PATCH, _MINOR, or _MAJOR.

CMake's builtin PROJECT_VERSION_* variables are not backward
compatible and not used here.
@xlz
Fix up coding style to suppress -Wall warnings
2e91125
@xlz
Plug some memory leaks
11f4c56 
viewer.{h,cpp} are ignored this time.
@xlz xlz mentioned this pull request Jan 7, 2016
Closed
@xlz
Copy link
Member Author

xlz commented Jan 7, 2016

There are a few more things that I'm not sure if needed after this PR.

  • A standalone LICENSE file to describe the license of this project, and attribute third party licenses. Right now it is OK though because the licenses are written in the headers, but binary release needs a standalone file. Added out of repository
  • Binary release specific documentation. INSTALL.txt: manual installation of VC++ runtime, dependency on OpenCL.dll, libusbK driver. examples/HOWTO.txt. Added out of repository
  • Possible usbdk replacement for libusbK, if that improves things for Windows 7 users. It does not work.
  • I guess there are some issues with freenect2.pc.in and freenect2.cmake.in that are specific to distro policies, but without feedback of packagers I don't know exactly. Ignore.
  • What to do with static library. There is nominal build support, but I never tested it and do not know how static build can be used. Ignore.

@xlz
Copy link
Member Author

xlz commented Jan 8, 2016

Tested: Debian, Ubuntu 14.04 with iai_kinect2, Windowss 8.1, Ubuntu 14.04 on Jetson.

@xlz
Copy link
Member Author

xlz commented Jan 9, 2016

Add this packaging stuff which has no effect on testing results.

@RyanGordon
Copy link
Contributor

Tested build and all 3 Protonect modes on Mac OSX 10.11 and everything appears to be working

@floe
Copy link
Contributor

floe commented Jan 18, 2016

Great, all platforms done! I think that's really the last one for 0.1. Thanks everyone, and @xlz in particular. Merging.

floe added a commit that referenced this pull request Jan 18, 2016
@floe
Merge pull request #530 from xlz/release-cleanup
3758042 
Release cleanup, fix memleaks, packaging helpers.
@floe floe merged commit 3758042 into OpenKinect:master Jan 18, 2016
@xlz xlz deleted the release-cleanup branch January 19, 2016 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xlz @RyanGordon @floe