-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add XKoreProxy (Xkore 3) support for vRO #3529
base: master
Are you sure you want to change the base?
Conversation
I think that we should move the code for receiving the token into a separate plugin. Let's try using the vRO_auth.pl plugin? |
Yes, please go ahead |
@@ -715,4 +757,124 @@ sub getRecvPackets { | |||
return \%rpackets; | |||
} | |||
|
|||
sub DecryptMessageID { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is already defined at https://github.com/Openkore/openkore/blob/master/src/Network/XKoreProxy.pm#L688
return $MID; | ||
} | ||
|
||
sub sendMasterLogin { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do $messageSender->sendMasterLogin instead of redefining this function.
$messageSender->sendToServer($data); | ||
debug "Sent sendMasterLogin\n", "sendPacket", 2; | ||
} | ||
sub pinEncode { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do $messageSender->sendLoginPinCode instead of redefining this function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you created a new commit with your edit please. I'm a little bit busy these days.
No description provided.