Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacing package "player_equipment" and "job_equipment_hair_change" with "sprite_change" #3899

Merged
merged 2 commits into from
Dec 15, 2024

Conversation

ya4ept
Copy link
Contributor

@ya4ept ya4ept commented Dec 14, 2024

replacing package "player_equipment" and "job_equipment_hair_change" with "sprite_change"

  • renamed package "player_equipment" to "sprite_change"
  • removed package "job_equipment_hair_change"

I only tested package 01D7 (on idRO server), I didn't test package 00C3

Player zzccds (0) changed Upper headgear to Nothing (0)
Player zzccds (0) changed Upper headgear to Egg Shell (101)
Player zzccds (0) changed Robe to: None (0)
Player zzccds (0) changed Upper headgear to Nothing (0)
Player zzccds (0) changed Weapon to None (0)
Player zzccds (0) changed Weapon to Novice Cutter [3] (13040)
Player zzccds (0) changed Weapon to None (0)
Player zzccds (0) changed Weapon to Novice Knife (1243)
Player zzccds (0) changed Upper headgear to Nothing (0)
Player zzccds (0) changed Upper headgear to Egg Shell (101)
Player zzccds (0) changed Weapon to None (0)
Player zzccds (0) changed Weapon to Novice Cutter [3] (13040)

We have problems when the player puts on the robe:
image

The server sends the sprite ID instead of the item ID. At the moment we do not support this functionality.

------------------- Inventory --------------------
-- Equipment (Not Equipped) --
6    Club [4] (Weapon) -- Not Identified                  
7    Novice Cutter [3] (Weapon)                           
8    Novice Knife (Weapon)                                
9    Novice Hood (Armor)                                  
10   Novice Adventurer's Suit [1] (Armor)                 
11   Novice Guard (Armor)                                 
12   Novice Boots (Armor)                                 
15   Costume Blue School Bag (Armor)                      
--------------------------------------------------

eq 10
You equip Novice Adventurer's Suit [1] (10) - Armor (type 16)

eq 15
You changed Robe to: None (0)
You changed Robe to: SPRITE_ROBE_ID=51
You equip Costume Blue School Bag (15) - Visual Cape (type 8192)

this is the sprite id from the file "spriterobeid.lub":

SPRITE_ROBE_IDs = {
...
	ROBE_C_School_Bag_BU = 105,
...
}

spriterobename.lub:

RobeNameTable = {
...
	[SPRITE_ROBE_IDs.ROBE_C_School_Bag_BU] = "C_School_Bag_BU",
...
}

image

…with "sprite_change"

- renamed package "player_equipment" to "sprite_change"
- removed package "job_equipment_hair_change"
@ya4ept ya4ept merged commit 0769af6 into master Dec 15, 2024
9 checks passed
@ya4ept ya4ept deleted the fix_sprite_change branch December 15, 2024 11:40
@dcyxxt
Copy link

dcyxxt commented Dec 16, 2024

when i used new vision ,i got You changed unknown sprite type (13), write about it to OpenKore developer

@ya4ept
Copy link
Contributor Author

ya4ept commented Dec 16, 2024

@dcyxxt please show full logs and create a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants