IntelliJ 2024.2: ProcessCanceledException class hierarchy changed. Resolve issues that arise from this API change.

[mrglavas]

Change in IntelliJ 2024.2 JetBrains/intellij-community@12e78f1#diff-53953a080bfbb7f3d529336a7318cfde6b06098f5fbb136f7c58c3fad831f500
See resolution in LSP4iJ: redhat-developer/lsp4ij#293.

LTI has multiple places with multi catch of CancellationException and ProcessCanceledException and will face the same problem.

LSP4iJ compilation errors that occurred with IntelliJ 2024.2:

[vaisakhkannan]

I haven't found the exact usage of the following in our code.
catch (CancellationException | ProcessCanceledException e)

I found usages of the following
catch (IndexNotReadyException | ProcessCanceledException | CancellationException e)

• AnnotationUtil.getScopeAnnotations()
• PostConstructReturnTypeQuickFix.resolveCodeAction()
• BeanValidationQuickFix.resolveRemoveConstraintAnnotationsCodeAction()
• BeanValidationQuickFix.resolveStaticModifierCodeAction()
• ManagedBeanNoArgConstructorQuickFix.resolveCodeAction()
• ManagedBeanQuickFix.resolveCodeAction()
• InsertAnnotationMissingQuickFix.resolveCodeAction()
• InsertAnnotationQuickFix.resolveCodeAction()
• RemoveAnnotationConflictQuickFix.resolveCodeAction()
• RemoveMethodParametersQuickFix.resolveCodeAction()
• RemoveModifierConflictQuickFix.resolveCodeAction()
• RemoveParamAnnotationQuickFix.resolveCodeAction()
• NoResourcePublicConstructorQuickFix.convertWorkspaceEdit()
• NonPublicResourceMethodQuickFix.resolveCodeAction()
• ResourceMethodMultipleEntityParamsQuickFix.resolveCodeAction()
• PersistenceAnnotationQuickFix.resolveCodeAction()
• PersistenceEntityQuickFix.resolveCodeAction()
• CompleteFilterAnnotationQuickFix.resolveCodeAction() --- 2 usages
• CompleteServletAnnotationQuickFix.resolveCodeAction() -- 2 usages
• FilterImplementationQuickFix.resolveCodeAction()
• HttpServletQuickFix.resolveCodeAction()
• ListenerImplementationQuickFix.resolveCodeAction()
• InsertAnnotationAttributeQuickFix.resolveCodeAction()
• InsertAnnotationMissingQuickFix.resolveCodeAction()
• AnnotationValidator.validate()
• JavaCompletionDefinition.isAdaptedForCompletion()
• JavaCompletionDefinition.collectCompletionItems()
• JavaDiagnosticsDefinition.isAdaptedForDiagnostics()
• JavaDiagnosticsDefinition.beginDiagnostics()
• JavaDiagnosticsDefinition.collectDiagnostics()
• JavaDiagnosticsDefinition.endDiagnostics()
• MicroProfileFaultToleranceASTValidator.validateAsynchronousAnnotation()
• ImplementHealthCheckQuickFix.resolveCodeAction()
• ApplicationScopedAnnotationMissingQuickFix.resolveCodeAction()
• MicroProfileGenerateOpenAPIOperation.resolveCodeAction()

I have made Fixes to the above occurrences.

[mrglavas]

@vaisakhkannan I've moved this back to parked. We're not targeting IntelliJ 2024.2 for 24.0.8. Will revisit when we do move up to 2024.2.

[vaisakhkannan]

The changes in the above PR 901 have been merged into the feature branch Support_intellij_2024.2. Those changes are required for @staicy123 to support 2024.2. We can revisit the PR changes once build.gradle starts building successfully.

[mrglavas]

@vaisakhkannan I noticed the PR was merged on to the feature branch without a code review. Adding review comments here about the code that was changed.

It would be desirable to refactor out common code so that the next time the exception handling requires an update, it won't require changes in so many places. For instance, this could be accomplished by writing a method which accepts a function (i.e. a lambda expression) as a parameter. The method would call the function which is wrapped in a try/catch. If the exception handling needs to be updated again then you only need to update the code in one place. In general if you find that you're making the same change in multiple places it could be a sign of duplicated code which could be improved.

[vaisakhkannan]

Closing this issue since the PR is merged