Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntelliJ 2024.2: Migrate to IntelliJ Platform Gradle Plugin 2.x #911

Closed
TrevCraw opened this issue Aug 13, 2024 · 4 comments
Closed

IntelliJ 2024.2: Migrate to IntelliJ Platform Gradle Plugin 2.x #911

TrevCraw opened this issue Aug 13, 2024 · 4 comments
Assignees
Milestone

Comments

@TrevCraw
Copy link
Contributor

As mentioned in Slack communication in the JetBrains Slack channel, plugins targeting 2024.2 must migrate from Gradle IntelliJ 1.x to IntelliJ Platform Gradle Plugin 2.x

More information on the migration can be found here: https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin-migration.html

Link to Slack message: https://jetbrains-platform.slack.com/archives/C5U8BM1MK/p1721656635063899

@staicy123
Copy link
Contributor

Hi @TrevCraw,
Here I am attaching the commit with all the changes made to support 2024.2 version in my forked feature branch. I have completed FVT for 2024.2 with java version 17 gradle and once I complete the FVT for 2024.2 with java version 21 and 2024.1 java version 17. I will raise the PR for the same. https://github.com/OpenLiberty/liberty-tools-intellij/compare/main...staicy123:liberty-tools-intellij:%23911-Migrate-Gradle-Plugin-2.x-intellij-2024.2?expand=1
Thanks

@staicy123
Copy link
Contributor

Hi @TrevCraw,
PR raised for the change here: #1053.
Please review and share your comments.

Thanks

@staicy123 staicy123 moved this from In Progress to In Review in Open Liberty Developer Experience Oct 30, 2024
@staicy123 staicy123 changed the title IntelliJ 2024.2: Migrate to IntelliJ Platform Gradle Plugin 2.x IntelliJ 2024.2: Migrate to IntelliJ Platform Gradle Plugin 2.x [In Review] Oct 30, 2024
@TrevCraw TrevCraw changed the title IntelliJ 2024.2: Migrate to IntelliJ Platform Gradle Plugin 2.x [In Review] IntelliJ 2024.2: Migrate to IntelliJ Platform Gradle Plugin 2.x Oct 30, 2024
staicy123 added a commit to staicy123/liberty-tools-intellij that referenced this issue Nov 8, 2024
@staicy123
Copy link
Contributor

Hi @TrevCraw ,
I have updated the PR with all the changes required for supporting 2024.2 intellij version for running buildPlugin task.
#1053
Unit test discussed here: #1048 (Needs to be fixed from jetbrains end)
Ui test:
Two issues needs to be addressed for this one

  1. Configure UI tests to run with Java 21 and 2024.2 #1088 (Started the analysis)
  2. Intelij: 2024.2 Investigation of Test Automation Changes in the Action Menu After Migration to Gradle IntelliJ Plugin 2.* and Modifications in runIdeForUiTests #1018 (In progress fixing test failures)

The PR for runIdeForUiTests task supporting intellij 2024.2 change in build.gradle will be raised by @vaisakhkannan once my changes are reviewed and merged.

Thanks

staicy123 added a commit that referenced this issue Nov 11, 2024
…-files

Added git ignore command to remove unwanted files
staicy123 added a commit to staicy123/liberty-tools-intellij that referenced this issue Nov 11, 2024
…-2024.2-by-updating-gradle-version' into OpenLiberty#911-Support-Intellij-2024.2-by-updating-gradle-version
staicy123 added a commit that referenced this issue Nov 18, 2024
…by-updating-gradle-version

#911 support intellij 2024.2 by updating gradle version
@staicy123
Copy link
Contributor

The changes have been successfully merged. Therefore, this ticket will be closed.

@github-project-automation github-project-automation bot moved this from In Review to Sprint Closed in Open Liberty Developer Experience Nov 18, 2024
dessina-devasia pushed a commit to dessina-devasia/liberty-tools-intellij that referenced this issue Nov 25, 2024
…nore-unwanted-logs-and-files

Added git ignore command to remove unwanted files
dessina-devasia pushed a commit to dessina-devasia/liberty-tools-intellij that referenced this issue Nov 25, 2024
…pport-Intellij-2024.2-by-updating-gradle-version

OpenLiberty#911 support intellij 2024.2 by updating gradle version
staicy123 added a commit that referenced this issue Nov 25, 2024
…arget-add-kotlin-import

Removed unused java target version and added import for kotlinCompile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants