Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1088 - Parameterize the java target and platform target values #1117

Conversation

anusreelakshmi934
Copy link
Contributor

@anusreelakshmi934 anusreelakshmi934 commented Nov 19, 2024

Fixes #1088

By default, tasks like runIde use the IntelliJ Platform version specified in the dependencies extension. I implemented a solution by creating a new task called runIdeLocally, enabling us to set custom values for the Java and IntelliJ versions. This allows us to use runIde with the specified platform version (java 17 ) and Intellij version 2024.1.7 and runIdeLocally with the latest version (2024.2.2 in this case) and java 21.

Also updated the places where runIde is used in our code to runIdeLocally.

build.gradle Outdated Show resolved Hide resolved
staicy123
staicy123 previously approved these changes Nov 21, 2024
Copy link
Contributor

@staicy123 staicy123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, changes look good.

Copy link
Contributor

@vaisakhkannan vaisakhkannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anusreelakshmi934 I can see in the Mac build that the IntelliJ Welcome frame is identified in the 23rd iteration. Do we need to increase the limit from 24?

Screenshot 2024-11-21 at 2 29 01 PM

@anusreelakshmi934
Copy link
Contributor Author

@anusreelakshmi934 I can see in the Mac build that the IntelliJ Welcome frame is identified in the 23rd iteration. Do we need to increase the limit from 24?

Screenshot 2024-11-21 at 2 29 01 PM

This doesn’t seem to be a consistently occurring scenario. In some builds, it succeeds much earlier, even before the 10th iteration. For now, setting it to 24 should be fine. If we encounter issues in the future, we can consider increasing it further.

vaisakhkannan
vaisakhkannan previously approved these changes Nov 21, 2024
Copy link
Contributor

@vaisakhkannan vaisakhkannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

check my comment in the issue 1067 here

I ran the GHA build today, with the updated UI changes along with this PR changes. Now, I can see that both unit and UI tests are passing on Linux, while on Windows, all unit tests are passing, but 2 UI tests failed ( one is known issue and one is intermitted , if I rerun it will resolve the problem)

Copy link
Contributor

@TrevCraw TrevCraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but have one question. What exactly do you mean by this statement?

we may need to update the runIde variable in our code to runIdeLocally, as we will be using runIdeLocally going forward.

@anusreelakshmi934
Copy link
Contributor Author

Changes look good, but have one question. What exactly do you mean by this statement?

we may need to update the runIde variable in our code to runIdeLocally, as we will be using runIdeLocally going forward.

I meant renaming all instances where we use runIde to runIdeLocally . I have made that change

@anusreelakshmi934 anusreelakshmi934 merged commit 8616f7c into OpenLiberty:intellij-2024.2-support Nov 22, 2024
0 of 3 checks passed
dessina-devasia pushed a commit to dessina-devasia/liberty-tools-intellij that referenced this pull request Nov 25, 2024
Issue OpenLiberty#1088 - Parameterize the java target and platform target values
@anusreelakshmi934 anusreelakshmi934 deleted the Issue-#1088 branch December 12, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure UI tests to run with Java 21 and 2024.2
4 participants