-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #1088 - Parameterize the java target and platform target values #1117
Issue #1088 - Parameterize the java target and platform target values #1117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, changes look good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anusreelakshmi934 I can see in the Mac build that the IntelliJ Welcome frame is identified in the 23rd iteration. Do we need to increase the limit from 24?
This doesn’t seem to be a consistently occurring scenario. In some builds, it succeeds much earlier, even before the 10th iteration. For now, setting it to 24 should be fine. If we encounter issues in the future, we can consider increasing it further. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
check my comment in the issue 1067 here
I ran the GHA build today, with the updated UI changes along with this PR changes. Now, I can see that both unit and UI tests are passing on Linux, while on Windows, all unit tests are passing, but 2 UI tests failed ( one is known issue and one is intermitted , if I rerun it will resolve the problem)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, but have one question. What exactly do you mean by this statement?
we may need to update the runIde variable in our code to runIdeLocally, as we will be using runIdeLocally going forward.
7888e2b
I meant renaming all instances where we use |
8616f7c
into
OpenLiberty:intellij-2024.2-support
Issue OpenLiberty#1088 - Parameterize the java target and platform target values
Fixes #1088
By default, tasks like runIde use the IntelliJ Platform version specified in the dependencies extension. I implemented a solution by creating a new task called
runIdeLocally
, enabling us to set custom values for the Java and IntelliJ versions. This allows us to userunIde
with the specified platform version (java 17 ) and Intellij version 2024.1.7 andrunIdeLocally
with the latest version (2024.2.2 in this case) and java 21.Also updated the places where
runIde
is used in our code torunIdeLocally
.