Timing #320
Merged
Timing #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leochr
reviewed
Mar 3, 2022
| if getErr != nil { | ||
| return r.ManageError(getErr, common.StatusConditionTypeReconciled, instance) | ||
| } | ||
| secrets := sa.Secrets |
There was a problem hiding this comment.
check on ImagePullSecret instead of Secrets
| @@ -335,6 +335,35 @@ func (r *ReconcileOpenLiberty) Reconcile(ctx context.Context, request ctrl.Reque | |||
| r.deletePVC(reqLogger, instance.Name+"-serviceability", instance.Namespace) | |||
| } | |||
|
|
|||
| // Check if the ServiceAccount has a valid pull secret before creating the deployment/statefulset | |||
There was a problem hiding this comment.
It'll be good to do this check after line 239 (before knative, since that could also be affected by this issue).
Also, this should be added to RCO's util package, so both RCO and OLO controllers can call it.
|
@idlewis merged RCO PR. When you get a chance, please update (or open new PR) to use the utils from RCO. We will need the same for WLO. Thank you. |
Specifically the change to utils/utils.go which adds a function to check for pull secrets
The cluster automatically creates pull secrets for the service account. This can take a while. Sometimes, the controller creates the deployment before the pull secret is created. This causes the pods to go into an image pull backoff loop. Check that the pull secret exists before the deployment is created, to prevent this
leochr
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To deal with the issue reported in #312