Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 2023-05-01-customize-your-openmage.md #122

Merged
merged 3 commits into from
May 2, 2023

Conversation

colinmollenhour
Copy link
Member

A blog post to help users with a common need that is probably a lot easier than most people realize.

Here is an example generating patches for `app/Mage.php`:

```sh
composer require symplify/vendor-patches --dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line can be removed. Was added as dev-req with zf1f.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it was necessary when I tried it.. I think to use it in a project which has openmage as a dependency I think it is still required because dev dependencies of packages are not installed by default. The guide is written for users which would be using openmage as a dependency, not the openmage devs.

@fballiano fballiano merged commit 36b5be3 into master May 2, 2023
@fballiano fballiano deleted the colinmollenhour-patch-1 branch May 2, 2023 10:15
@sreichel
Copy link
Contributor

sreichel commented May 3, 2023

The image should be (automatically) resized?

@ADDISON74
Copy link

ADDISON74 commented Jul 6, 2024

A very good documentation but it requires some changes in format and information.

  1. All PRs have a patch that can be downloaded as mentioned in the article by adding .patch at the end of the URL. If you look inside the file, there are conversations, changes/commits made over time. I recommend to edit these files and keep only the final changes before merging. For this reason it was strongly recommended over the years not to do PRs that modify a lot of files solving several issue in one place.

  2. If someone is using the DDEV environment, the command to run vendor patches is ddev exec vendor/bin/vendor-patches generate.

  3. Using the dry run option before patching.

@ADDISON74
Copy link

This change doesn't work in my case. My opinion there are missing steps.

{
  "...": "...",
  "extra": {
    "patches": {
      "openmage/magento-lts": {
        "Added form key validation to Contacts form #3146": "https://github.com/OpenMage/magento-lts/pull/3146.patch"
      }
    }
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants