Bump phpstan/phpstan from 1.10.8 to 1.10.10 (#3133)

Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>
OpenMage · Apr 3, 2023 · 8ec76c2 · 8ec76c2
1 parent 6b66b31
commit 8ec76c2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 110 deletions.
diff --git a/composer.lock b/composer.lock
diff --git a/phpstan.dist.baseline.neon b/phpstan.dist.baseline.neon
@@ -325,11 +325,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Adminhtml/Block/Tax/Rate/Grid/Renderer/Data.php
 
-		-
-			message: "#^Variable \\$category in empty\\(\\) always exists and is not falsy\\.$#"
-			count: 1
-			path: app/code/core/Mage/Adminhtml/Block/Urlrewrite/Category/Tree.php
-
 		-
 			message: "#^Method Mage_Adminhtml_Block_Widget_Container\\:\\:_addButtonChildBlock\\(\\) should return Mage_Adminhtml_Block_Widget_Button but returns Mage_Core_Block_Abstract\\|false\\.$#"
 			count: 1
@@ -1430,11 +1425,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Catalog/Model/Product/Option/Type/File.php
 
-		-
-			message: "#^Variable \\$value in isset\\(\\) always exists and is not nullable\\.$#"
-			count: 1
-			path: app/code/core/Mage/Catalog/Model/Product/Option/Type/File.php
-
 		-
 			message: "#^Elseif condition is always true\\.$#"
 			count: 2
@@ -1535,11 +1525,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Catalog/Model/Resource/Category.php
 
-		-
-			message: "#^Variable \\$ids in empty\\(\\) always exists and is not falsy\\.$#"
-			count: 1
-			path: app/code/core/Mage/Catalog/Model/Resource/Category/Collection.php
-
 		-
 			message: "#^Call to an undefined method Mage_Catalog_Model_Resource_Category_Collection\\:\\:addSortedField\\(\\)\\.$#"
 			count: 1
@@ -1550,11 +1535,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Catalog/Model/Resource/Category/Flat/Collection.php
 
-		-
-			message: "#^Variable \\$ids in empty\\(\\) always exists and is not falsy\\.$#"
-			count: 1
-			path: app/code/core/Mage/Catalog/Model/Resource/Category/Flat/Collection.php
-
 		-
 			message: "#^Call to an undefined method Zend_Db_Select\\:\\:insertFromSelect\\(\\)\\.$#"
 			count: 1
@@ -1730,11 +1710,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/CatalogIndex/Model/Indexer.php
 
-		-
-			message: "#^Variable \\$kill in isset\\(\\) always exists and is not nullable\\.$#"
-			count: 1
-			path: app/code/core/Mage/CatalogIndex/Model/Indexer.php
-
 		-
 			message: "#^Return type \\(string\\) of method Mage_CatalogIndex_Model_Indexer_Eav\\:\\:_getIndexableAttributeConditions\\(\\) should be compatible with return type \\(array\\) of method Mage_CatalogIndex_Model_Indexer_Abstract\\:\\:_getIndexableAttributeConditions\\(\\)$#"
 			count: 1
@@ -1790,11 +1765,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/CatalogInventory/Model/Stock/Item.php
 
-		-
-			message: "#^Variable \\$parentItem in empty\\(\\) always exists and is not falsy\\.$#"
-			count: 1
-			path: app/code/core/Mage/CatalogInventory/Model/Stock/Item.php
-
 		-
 			message: "#^Return type \\(int\\) of method Mage_CatalogRule_Model_Action_Index_Refresh_Row\\:\\:_getProduct\\(\\) should be compatible with return type \\(null\\) of method Mage_CatalogRule_Model_Action_Index_Refresh\\:\\:_getProduct\\(\\)$#"
 			count: 1
@@ -1845,11 +1815,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Checkout/Block/Cart/Crosssell.php
 
-		-
-			message: "#^Loose comparison using \\=\\= between numeric\\-string and '' will always evaluate to false\\.$#"
-			count: 1
-			path: app/code/core/Mage/Checkout/Block/Cart/Item/Renderer.php
-
 		-
 			message: "#^Property Mage_Checkout_Block_Cart_Shipping\\:\\:\\$_address \\(array\\) does not accept Mage_Sales_Model_Quote_Address\\.$#"
 			count: 1
@@ -1945,11 +1910,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Checkout/Model/Type/Multishipping.php
 
-		-
-			message: "#^Variable \\$paymentMethod in empty\\(\\) always exists and is not falsy\\.$#"
-			count: 1
-			path: app/code/core/Mage/Checkout/Model/Type/Multishipping.php
-
 		-
 			message: "#^Negated boolean expression is always true\\.$#"
 			count: 1
@@ -1980,11 +1940,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/ConfigurableSwatches/Helper/Productimg.php
 
-		-
-			message: "#^Variable \\$mediaGalleryImages in empty\\(\\) always exists and is not falsy\\.$#"
-			count: 1
-			path: app/code/core/Mage/ConfigurableSwatches/Helper/Productimg.php
-
 		-
 			message: "#^Method Mage_Core_Block_Abstract\\:\\:_getUrlModel\\(\\) should return Mage_Core_Model_Url but returns Mage_Core_Model_Abstract\\|false\\.$#"
 			count: 1
@@ -2110,11 +2065,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Core/Model/App.php
 
-		-
-			message: "#^Variable \\$id in isset\\(\\) always exists and is not nullable\\.$#"
-			count: 1
-			path: app/code/core/Mage/Core/Model/App.php
-
 		-
 			message: "#^Method Mage_Core_Model_Cache\\:\\:getDbAdapter\\(\\) should return Zend_Db_Adapter_Abstract but returns Varien_Db_Adapter_Interface\\|false\\.$#"
 			count: 1
@@ -2725,11 +2675,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Directory/Model/Currency/Import/Webservicex.php
 
-		-
-			message: "#^Variable \\$allowCountries in empty\\(\\) always exists and is not falsy\\.$#"
-			count: 1
-			path: app/code/core/Mage/Directory/Model/Resource/Country/Collection.php
-
 		-
 			message: "#^Method Mage_Downloadable_Block_Adminhtml_Catalog_Product_Edit_Tab_Downloadable_Links\\:\\:getPurchasedSeparatelyAttribute\\(\\) should return Mage_Catalog_Model_Resource_Eav_Attribute but returns Mage_Eav_Model_Entity_Attribute\\.$#"
 			count: 1
@@ -3600,21 +3545,11 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Paypal/Model/Payflowlink.php
 
-		-
-			message: "#^Variable \\$order in empty\\(\\) always exists and is not falsy\\.$#"
-			count: 1
-			path: app/code/core/Mage/Paypal/Model/Payflowlink.php
-
 		-
 			message: "#^Property Mage_Paypal_Model_Payflowpro\\:\\:\\$_centinelFieldMap \\(string\\) does not accept default value of type array\\<string, string\\>\\.$#"
 			count: 1
 			path: app/code/core/Mage/Paypal/Model/Payflowpro.php
 
-		-
-			message: "#^Variable \\$order in empty\\(\\) always exists and is not falsy\\.$#"
-			count: 1
-			path: app/code/core/Mage/Paypal/Model/Payflowpro.php
-
 		-
 			message: "#^Method Mage_Paypal_Model_Pro\\:\\:capture\\(\\) should return false\\|null but return statement is missing\\.$#"
 			count: 1
@@ -3685,11 +3620,6 @@ parameters:
 			count: 2
 			path: app/code/core/Mage/Rating/Model/Resource/Rating/Collection.php
 
-		-
-			message: "#^Variable \\$storeId in empty\\(\\) always exists and is not falsy\\.$#"
-			count: 1
-			path: app/code/core/Mage/Rating/Model/Resource/Rating/Collection.php
-
 		-
 			message: "#^Method Mage_Rating_Model_Resource_Rating_Entity\\:\\:getIdByCode\\(\\) should return int but returns string\\|false\\|null\\.$#"
 			count: 1
@@ -3760,11 +3690,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Reports/Model/Resource/Report/Product/Viewed/Collection.php
 
-		-
-			message: "#^Variable \\$currentStoreIds in isset\\(\\) always exists and is not nullable\\.$#"
-			count: 1
-			path: app/code/core/Mage/Reports/Model/Resource/Report/Product/Viewed/Collection.php
-
 		-
 			message: "#^Call to an undefined method Mage_Reports_Model_Resource_Review_Collection\\:\\:_joinFields\\(\\)\\.$#"
 			count: 1
@@ -4050,11 +3975,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Sales/Model/Quote.php
 
-		-
-			message: "#^Variable \\$old in empty\\(\\) always exists and is not falsy\\.$#"
-			count: 2
-			path: app/code/core/Mage/Sales/Model/Quote.php
-
 		-
 			message: "#^Method Mage_Sales_Model_Quote_Address\\:\\:getItemsCollection\\(\\) should return Mage_Eav_Model_Entity_Collection_Abstract but returns Mage_Sales_Model_Resource_Quote_Address_Item_Collection\\.$#"
 			count: 1
@@ -4215,11 +4135,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Sales/Model/Resource/Report/Bestsellers/Collection.php
 
-		-
-			message: "#^Variable \\$currentStoreIds in isset\\(\\) always exists and is not nullable\\.$#"
-			count: 1
-			path: app/code/core/Mage/Sales/Model/Resource/Report/Bestsellers/Collection.php
-
 		-
 			message: "#^Call to an undefined method Varien_Db_Adapter_Interface\\:\\:listTables\\(\\)\\.$#"
 			count: 1
@@ -4330,11 +4245,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Shipping/Model/Carrier/Tablerate.php
 
-		-
-			message: "#^Variable \\$rate in empty\\(\\) always exists and is not falsy\\.$#"
-			count: 3
-			path: app/code/core/Mage/Shipping/Model/Carrier/Tablerate.php
-
 		-
 			message: "#^If condition is always false\\.$#"
 			count: 1
@@ -4375,11 +4285,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Tag/Block/Customer/Tags.php
 
-		-
-			message: "#^Variable \\$tags in isset\\(\\) always exists and is not nullable\\.$#"
-			count: 1
-			path: app/code/core/Mage/Tag/Block/Customer/Tags.php
-
 		-
 			message: "#^Method Mage_Tag_Block_Product_List\\:\\:_beforeToHtml\\(\\) should return \\$this\\(Mage_Tag_Block_Product_List\\) but returns false\\.$#"
 			count: 1
@@ -4690,11 +4595,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Weee/Helper/Data.php
 
-		-
-			message: "#^Variable \\$title in isset\\(\\) always exists and is not nullable\\.$#"
-			count: 1
-			path: app/code/core/Mage/Weee/Helper/Data.php
-
 		-
 			message: "#^Return type \\(\\$this\\(Mage_Weee_Model_Attribute_Backend_Weee_Tax\\)\\) of method Mage_Weee_Model_Attribute_Backend_Weee_Tax\\:\\:validate\\(\\) should be compatible with return type \\(bool\\) of method Mage_Eav_Model_Entity_Attribute_Backend_Abstract\\:\\:validate\\(\\)$#"
 			count: 1
@@ -4760,11 +4660,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Wishlist/Model/Item.php
 
-		-
-			message: "#^Variable \\$buyRequest in empty\\(\\) always exists and is not falsy\\.$#"
-			count: 2
-			path: app/code/core/Mage/Wishlist/Model/Item.php
-
 		-
 			message: "#^Method Mage_Wishlist_Model_Item_Option\\:\\:__clone\\(\\) with return type void returns \\$this\\(Mage_Wishlist_Model_Item_Option\\) but should not return anything\\.$#"
 			count: 1