Removed PHPStan stubs (#3210)

OpenMage · Apr 26, 2023 · cb6791b · cb6791b
1 parent 998e306
commit cb6791b
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 27 deletions.
diff --git a/app/code/core/Mage/Captcha/Model/Zend.php b/app/code/core/Mage/Captcha/Model/Zend.php
@@ -64,7 +64,7 @@ class Mage_Captcha_Model_Zend extends Zend_Captcha_Image implements Mage_Captcha
     /**
      * Generated word
      *
-     * @var string|null
+     * @var string
      */
     protected $_word;
 
@@ -483,7 +483,7 @@ protected function _setWord($word)
     protected function _clearWord()
     {
         $this->getSession()->unsetData($this->_getFormIdKey(self::SESSION_WORD));
-        $this->_word = null;
+        $this->_word = '';
         return $this;
     }
 

diff --git a/app/code/core/Mage/Eav/Model/Adminhtml/System/Config/Source/Inputtype/Validator.php b/app/code/core/Mage/Eav/Model/Adminhtml/System/Config/Source/Inputtype/Validator.php
@@ -22,7 +22,7 @@
 class Mage_Eav_Model_Adminhtml_System_Config_Source_Inputtype_Validator extends Zend_Validate_InArray
 {
     /**
-     * @var array<string, string>|null
+     * @inheritdoc
      */
     protected $_messageTemplates;
 
@@ -34,7 +34,7 @@ public function __construct()
         $haystack = $helper->getInputTypesValidatorData();
 
         //reset message template and set custom
-        $this->_messageTemplates = null;
+        $this->_messageTemplates = [];
         $this->_initMessageTemplates();
 
         //parent construct with options

diff --git a/dev/phpstan/stubs/Zend_Captcha_Word.stub b/dev/phpstan/stubs/Zend_Captcha_Word.stub
diff --git a/dev/phpstan/stubs/Zend_Validate_InArray.stub b/dev/phpstan/stubs/Zend_Validate_InArray.stub
diff --git a/phpstan.dist.neon b/phpstan.dist.neon
@@ -71,9 +71,6 @@ parameters:
 
         # Instantiated class not found
         - lib/Varien/Image/Adapter.php
-    stubFiles:
-        - dev/phpstan/stubs/Zend_Captcha_Word.stub
-        - dev/phpstan/stubs/Zend_Validate_InArray.stub
     level: 4
     checkFunctionNameCase: true
     checkInternalClassCaseSensitivity: true