Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New admin theme: date fields to small #2397

Closed
sreichel opened this issue Aug 10, 2022 · 2 comments · Fixed by #2422
Closed

New admin theme: date fields to small #2397

sreichel opened this issue Aug 10, 2022 · 2 comments · Fixed by #2422
Labels

Comments

@sreichel
Copy link
Contributor

Preconditions (*)

  1. OM 19.4.17
  2. new admin theme

Steps to reproduce (*)

  1. got to catalog price rules

Expected result (*)

grid2

Actual result (*)

grid1


Change CSS min-width for .grid tr.filter .range div.date?

@sreichel sreichel added the bug label Aug 10, 2022
@addison74
Copy link
Contributor

addison74 commented Aug 10, 2022

The issue comes from this PR #2330. When I created it I didn't test the OpenMage theme, I never used it. The interesting part is that the values I set are the optimal ones, if they change they must be analyzed because I was at the limit with them.

In the future, I plan a review of all the grids in the Backend so that the types of columns are set in boxes.css and only when necessary they are set in Grids.php. But it will take time because there are around 160 files that need to be evaluated. I created a post related to this issue here #2239.

@addison74
Copy link
Contributor

It is not the only visual issue, here's another one

screenshot

I tried to make changes to look good in the OpenMage theme but the arrangement in the Magento theme is broken.

At first glance I would say that the Magento theme and the OpenMage theme should not share the same boxes.css file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants