Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new event adminhtml_block_widget_tabs_html_before, for adding custom tab. #1358

Merged
merged 3 commits into from
Mar 11, 2021

Conversation

kiatng
Copy link
Contributor

@kiatng kiatng commented Dec 18, 2020

Description (*)

Ref PR #879 on adding tab in pages in adminhtml where the event name was adminhtml_widget_tabs_html_before. But it hsould be adminhtml_block_widget_tabs_html_before for name consistency. The other event that can be used to add tab is core_block_abstract_to_html_before, but it's fired for every block in frontend and backend.

Related Pull Requests

PR #879.

Fixed Issues (if relevant)

  1. Fixes OpenMage/magento-lts#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label Dec 18, 2020
@sreichel sreichel merged commit 62de637 into OpenMage:1.9.4.x Mar 11, 2021
@sreichel sreichel added this to the Release 19.4.12 / 20.0.8 milestone Mar 11, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  1 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌
2 runs  2 ✔️ 0 💤 0 ❌

Results for commit 62de637.

@sreichel sreichel mentioned this pull request Mar 11, 2021
3 tasks
@Flyingmana Flyingmana changed the title Changed event name adminhtml_block_widget_tabs_html_before, add 'block' for name consistency. Add a new event adminhtml_block_widget_tabs_html_before, for adding custom tab. Apr 6, 2021
@kiatng kiatng deleted the tabs_event branch May 31, 2021 01:27
@kiatng kiatng mentioned this pull request May 31, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants