Improved global search performance by using only prefix matching. #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Adminhtml
kkrieger85
previously approved these changes
May 12, 2021
|
fixed conflicts |
|
Thanks for fixing conflicts but it looks like it restored the two postcode lines that were intended to be removed. |
|
so sorry, should have fixed it now :-( |
colinmollenhour
force-pushed
the
improve-global-search
branch
from
e609ed3
to
8f2f022
Compare
colinmollenhour
added
the
Rebased: RFC-0002
matteotestoni
approved these changes
Apr 5, 2023
fballiano
approved these changes
Apr 5, 2023
fballiano
changed the title
kiatng
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the postcode search (with a large store searching by postcode will be useless) and uses only prefix match for catalog search.
I don't have a large instance handy to test with, if someone does and can profile the database queries to identify which ones are slow and provide an "explain" that would be helpful.
Refs #134