-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove frontend_type tag for text #2148
Conversation
I will rebase on top of 1.9.4.x for added configurations. |
May I suggest a small change in PR description? "For each system.xml file in a Magento module directory ...". I did not test the PR but it is interesting the observation made by you related to the uselessness of those tags in the cascade. I'm sure you did a simulation after which you realized this issue. |
I realized that Magento use this tag everywhere in #2086. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me. Definitely a worth it improvement!
Description
For each system.xml file in module directory, we have:
For
example1
andexample2
tags,<frontend_type>text</frontend_type>
are not needed.For
example3
tag,<frontend_type>text</frontend_type>
is the default value, so not really required.So, because it's more easy to remove all, I removed all tags.
Moreover, this will reduce the size of the merged XML in memory.
After #1916, this will also reduce the size of the cache.
Contribution checklist