New feature: Allow admin to create guest orders and reorder as guest #2233

justinbeaty · 2022-06-18T21:37:44Z

Description (*)

One of my store managers mentioned in passing how she got around having to replace an order for a guest checkout. I am not sure why this is not possible in stock Magento. Maybe there is a good reason, but it seems to work just fine.

Related Pull Requests

Fixed Issues (if relevant)

Fixes Add re-order button #244

Manual testing scenarios (*)

Place a guest order
Press the newly available "reorder" button in admin
All details show up, and the order seems to be placed fine.

Questions or comments

Does anyone know why Magento has this disabled? I see others on Stackoverflow as well as in the linked issue asking about it, but the stack overflow answer involved changing a block to add the button: https://magento.stackexchange.com/questions/86531/re-order-for-guests-in-magento

I did PR into 20.0 in case it's breaking in any way.

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All automated tests passed successfully (all builds are green)
Add yourself to contributors list

justinbeaty · 2022-06-18T22:17:48Z

I made this PR too early, I do see some issues.

On the second order, customer name is "Guest" and customer group ID is default customer group, not "NOT LOGGED IN".

I think this is because there's a default customer object attached, and for example that sets the customer group to the default from config.

I will investigate this more and push changes if possible.

ADDISON74 · 2022-06-19T07:12:13Z

I would first evaluate whether this feature is useful and how often it is used.

On the customer's side if he has an account then he can place any past order that he can edit in the shopping cart. As a store I would encourage guest buyers to set up accounts and present the reasons maybe give bonuses.

On the administrator side we can have several situations. You are asked by a guest customer to place an order from the past and this button is useful. You look for the order and place it again. I have never personally encountered this situation. Secondly, I do not recommend this way to be done by the administrator in stores where it is necessary for that customer to agree to the terms and conditions, but also to the processing of personal data.

We can also have the situation described by you but here it is either a request of editing a current open order, or of doubling the existing one with cancellation. Magento did not allow the editing of orders and I consider this a lack as long as you have the customer's consent to do some actions when you do not have the product, quantity or assortment available in stock.

If it is up to me I would implement an option in the store configuration let's say Orders section so that this Reorder button appears or not depending on what the administrator decides. E.g. only for registered customer, only for Guest, for both or not at all. I have this approach because there are stores where more users could have access to the Orders section in Backend and the administrator must decide the appearance of the button. The default value I would set it for "Don't show it" because of the reasons related to legal issues.

If what I said above is not wanted or will not be implemented and if this button still appears for the registered customer orders, I don't see any reason why it wouldn't appear for the guests as well.

justinbeaty · 2022-06-19T12:13:37Z

@ADDISON74 The main reason the store manager needs to reorder a guest order is that the carrier has lost the package in transit, or it arrives damages. In that case, the manager would create a new order, change the price to $0 on each product, and submit so it can be fulfilled as normal during order processing.

Right now, they have to open the old order in a separate window and manually copy each part of the billing/shipping address and re-add the items to the quote, which is time consuming and can be error prone.

As for the config, there is already the option in the admin configuration, but I believe this controls the frontend reorder button as well. Turning it off will definitely remove the reorder button in the admin too. That option could be expanded in another PR to include more options. For this PR however, I think it was probably just a bug that reorder didn't work for guest checkout, so the Magento devs just hid the button as a workaround.

justinbeaty · 2022-06-21T15:44:21Z

Pushed commit, admin is now able to create a new guest order, as well as reorder a guest order. I have done light testing and it seems to work so far, I will test more thoroughly.

Screenshot of Sales > Orders > Create New Order:

There was very clearly support at one time for this feature, as evidenced by snippets of code below in the current code. I do not know at what point the Magento team probably broke the feature and just decided to hide the "Reorder" button on guest orders.

magento-lts/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Form/Account.php

Lines 81 to 83 in bafc48f

    
           if ($this->getQuote()->getCustomerIsGuest()) { 
        
               unset($attributes['group_id']); 
        
           }

magento-lts/app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php

Lines 359 to 361 in bafc48f

    
           if (!$order->getCustomerId()) { 
        
               $quote->setCustomerIsGuest(true); 
        
           }

magento-lts/app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php

Lines 1383 to 1385 in bafc48f

    
           if ($quote->getCustomerIsGuest()) { 
        
               return $this; 
        
           }

magento-lts/app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php

Lines 1561 to 1562 in bafc48f

    
           if ((!$customer->getId() || !$customer->isInStore($this->getSession()->getStore())) 
        
               && !$quote->getCustomerIsGuest()

justinbeaty · 2022-06-21T16:39:18Z

I added a couple of comments on parts of the PR to explain what is happening to make the changes more clear.

ADDISON74 · 2022-06-21T18:36:11Z

I appreciate your effort. Do you have a screenshot of the buttons in the Sales > Orders section?

justinbeaty · 2022-06-21T20:17:59Z

@ADDISON74

Sales > Orders (Nothing changed)

Sales > Orders > Create New Order (Added "Create Guest Order" button)

Order View (Added "Reorder" button for guest order)

justinbeaty · 2022-06-21T16:27:02Z

app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php

@@ -1490,7 +1493,7 @@ public function _prepareCustomer()
            $this->_getCustomerForm()
                ->setEntity($customer)
                ->resetEntityData();
-        } else {
+        } elseif ($customer->getGroupId() !== Mage_Customer_Model_Group::NOT_LOGGED_IN_ID) {


This could also check !$quote->getCustomerIsGuest() instead of checking $customer->getGroupId().

I chose the latter because the if was also checking the $customer object, but the former is maybe better since it's the same as the conditional I removed at the top of the method. I may push this as a change.

app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Customer.php

justinbeaty · 2022-06-21T16:32:45Z

app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Form/Account.php

+        // if quote is guest, unset customer_group_id
        if ($this->getQuote()->getCustomerIsGuest()) {
            unset($attributes['group_id']);
        }


This comment should read:

// if quote is guest, unset group_id dropdown

As it removes the customer group dropdown on the order create screen if we're creating a guest order. I will change and push.

app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php

app/code/core/Mage/Sales/Model/Order.php

ADDISON74 · 2022-06-21T18:04:52Z

app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Customer.php

@@ -48,12 +48,23 @@ public function getHeaderText()

    public function getButtonsHtml()
    {
+        $html = '';
+
        $addButtonData = array(
            'label'     => Mage::helper('sales')->__('Create New Customer'),
            'onclick'   => 'order.setCustomerId(false)',
            'class'     => 'add',
        );


Even if it's not part of the change wouldn't it be better to be here "Create Customer Order"? In doesn't matter if is a New Customer or a Registered one. At least we keep two buttons with a clear message:

[Create Customer Order] [Create Guest Order]

@ADDISON74 the first button really creates a new customer so I think it can be left as it is

empiricompany · 2023-12-10T10:58:44Z

I just found this PR now. It's a useful and also non-intrusive feature.
I tested it and it works correctly on 20.0.14

sreichel · 2023-12-10T11:54:30Z

Makes no sense to me to have reoders for guests. Then it needs no guest account. Same for admin created orders.

justinbeaty · 2023-12-10T11:58:20Z

@sreichel how about if the order arrived damaged and we need to send a new one. It’s tedious to manually copy every field, especially address.

I will see if I can rebase today.

empiricompany · 2023-12-11T07:41:11Z

Makes no sense to me to have reoders for guests. Then it needs no guest account. Same for admin created orders.

It would be useful to us in some cases where the customer needs to create orders on the fly, for example at expos events.

sreichel · 2023-12-11T10:13:27Z

Of course it can be useful in some cases, but is it something that is used by many users?

Im not an expert, but does it not violate GDPR/DSVGO?

Data from guest orders is not meant to be for operational processes. (???)

(Creating guest orders from backend ... why?)

fballiano · 2023-12-11T10:16:47Z

I agree with this PR and AFAIK it doesn't create problems with GDPR, but it has conflicts and notes to be addressed.

sreichel · 2023-12-11T10:29:40Z

Guest orders are for "anonymized" data. Of course they are in your DB, but only for legal/financial purposes.

For backend orders you have a phone call, an email, ... why to create a guest order? (Also from sellers view?!?)

Imho it better to an extension.

fballiano · 2023-12-11T10:31:26Z

I still think it's useful when somebody created a guest order from the frontend and needs a reorder or when customer-service has to create a one-stop order for somebody.

justinbeaty · 2023-12-11T12:09:09Z

I think simple the fact that it seems to have been supported in core at one point but disabled (probably due to some bug and they were lazy) is enough to warrant this PR: #2233 (comment)

fballiano

tested, it works fine for me.

without this PR I can reorder a guest order but then the duplicated order has the wrong customer_group

with this PR the customer_group is correct

github-actions bot added the Component: Sales Relates to Mage_Sales label Jun 18, 2022

ADDISON74 linked an issue Jun 18, 2022 that may be closed by this pull request

Add re-order button #244

Closed

justinbeaty marked this pull request as draft June 18, 2022 22:16

fballiano force-pushed the topic-guest-reorder branch from 6045b4a to 8637b3f Compare June 21, 2022 09:36

Allow admin guest order and reorder

2a5713c

justinbeaty force-pushed the topic-guest-reorder branch from 8637b3f to 2a5713c Compare June 21, 2022 15:35

github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml JavaScript Relates to js/* labels Jun 21, 2022

justinbeaty changed the title ~~Allow guest reorders~~ Allow admin guest order and reorder Jun 21, 2022

justinbeaty commented Jul 17, 2022

View reviewed changes

fballiano changed the base branch from 20.0 to main April 4, 2023 17:33

matteotestoni approved these changes Apr 5, 2023

View reviewed changes

ADDISON74 requested changes Jul 10, 2023

View reviewed changes

ADDISON74 self-assigned this Jul 14, 2023

fballiano added 2 commits December 11, 2023 12:38

Merge branch 'main' into topic-guest-reorder

f1fe65d

Merge branch 'main' into topic-guest-reorder

4f2efbb

github-actions bot removed the Component: Sales Relates to Mage_Sales label Feb 14, 2024

phpcs

14be50b

fballiano approved these changes Feb 14, 2024

View reviewed changes

fballiano marked this pull request as ready for review February 14, 2024 14:55

empiricompany approved these changes Feb 14, 2024

View reviewed changes

fballiano changed the title ~~Allow admin guest order and reorder~~ New feature: Allow admin to create guest orders and reorder as guest Feb 16, 2024

fballiano merged commit d5805b6 into OpenMage:main Feb 16, 2024
17 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New feature: Allow admin to create guest orders and reorder as guest #2233

New feature: Allow admin to create guest orders and reorder as guest #2233

justinbeaty commented Jun 18, 2022 •

edited

Loading

justinbeaty commented Jun 18, 2022

ADDISON74 commented Jun 19, 2022

justinbeaty commented Jun 19, 2022

justinbeaty commented Jun 21, 2022

justinbeaty commented Jun 21, 2022

ADDISON74 commented Jun 21, 2022

justinbeaty commented Jun 21, 2022

justinbeaty Jun 21, 2022

justinbeaty Jun 21, 2022

ADDISON74 Jun 21, 2022

fballiano Feb 14, 2024

empiricompany commented Dec 10, 2023

sreichel commented Dec 10, 2023

justinbeaty commented Dec 10, 2023

empiricompany commented Dec 11, 2023

sreichel commented Dec 11, 2023

fballiano commented Dec 11, 2023

sreichel commented Dec 11, 2023 •

edited

Loading

fballiano commented Dec 11, 2023

justinbeaty commented Dec 11, 2023

fballiano left a comment

New feature: Allow admin to create guest orders and reorder as guest #2233

New feature: Allow admin to create guest orders and reorder as guest #2233

Conversation

justinbeaty commented Jun 18, 2022 • edited Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

justinbeaty commented Jun 18, 2022

ADDISON74 commented Jun 19, 2022

justinbeaty commented Jun 19, 2022

justinbeaty commented Jun 21, 2022

justinbeaty commented Jun 21, 2022

ADDISON74 commented Jun 21, 2022

justinbeaty commented Jun 21, 2022

justinbeaty Jun 21, 2022

Choose a reason for hiding this comment

justinbeaty Jun 21, 2022

Choose a reason for hiding this comment

ADDISON74 Jun 21, 2022

Choose a reason for hiding this comment

fballiano Feb 14, 2024

Choose a reason for hiding this comment

empiricompany commented Dec 10, 2023

sreichel commented Dec 10, 2023

justinbeaty commented Dec 10, 2023

empiricompany commented Dec 11, 2023

sreichel commented Dec 11, 2023

fballiano commented Dec 11, 2023

sreichel commented Dec 11, 2023 • edited Loading

fballiano commented Dec 11, 2023

justinbeaty commented Dec 11, 2023

fballiano left a comment

Choose a reason for hiding this comment

justinbeaty commented Jun 18, 2022 •

edited

Loading

sreichel commented Dec 11, 2023 •

edited

Loading