autoload without hiding errors #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: lib/Varien
|
This looks like a much better solution. Should you use the original return value? return include $found;Maybe the return value not used anywhere though... |
you are right, will add it again |
justinbeaty
previously approved these changes
Jul 10, 2022
|
This is a simplest version of @Asfolny idea. I will test it! |
4 tasks
sreichel
reviewed
Dec 25, 2022
sreichel
requested review from
justinbeaty,
fballiano and
luigifab
and removed request for
justinbeaty
addison74
approved these changes
Dec 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Related Pull Requests
alternative to #1817
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)