Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Variable might not be defined" PHPStan error #2316

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Fix "Variable might not be defined" PHPStan error #2316

merged 1 commit into from
Jul 13, 2022

Conversation

elidrissidev
Copy link
Member

@elidrissidev elidrissidev commented Jul 13, 2022 •
edited by sreichel
Loading

Description (*)

This PHPStan error originated from my last PR but it didn't show up because the composer error made the workflow not run fully.

Related Pull Requests

  1. See Order add comment functionality in REST API #2315

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: Sales Relates to Mage_Sales label Jul 13, 2022
@fballiano fballiano merged commit d91170b into OpenMage:20.0 Jul 13, 2022
@github-actions
Copy link
Contributor

Unit Test Results

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d91170b. ± Comparison against base commit 1837f74.

@elidrissidev elidrissidev deleted the fix/phpstan-var-maybe-undefined branch July 14, 2022 08:38
@sreichel sreichel mentioned this pull request Nov 20, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 approved these changes

@fballiano fballiano fballiano approved these changes

Assignees
No one assigned
Labels
Component: Sales Relates to Mage_Sales
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elidrissidev @fballiano @addison74