Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant polyfill code for error reporting constants #2555

Conversation

elidrissidev
Copy link
Member

@elidrissidev elidrissidev commented Sep 5, 2022

Description (*)

This PR removes redundant polyfill code that defines some error reporting constants which should be available in all of our supported PHP versions anyways. Correct if I'm wrong as I couldn't find specific information about when these constants were introduced.

Manual testing scenarios (*)

  1. Everything should remain the same.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: Core Relates to Mage_Core label Sep 5, 2022
@fballiano
Copy link
Contributor

this is what I found

E_STRICT -> https://www.examveda.com/which-version-of-php-introduced-estrict-error-level-35395/
E_RECOVERABLE_ERROR -> https://www.php.net/releases/5_2_0.php
E_DEPRECATED -> https://electrictoolbox.com/php-prevent-e-deprecated-error-messages/

so you should be right assuming we don't need that code anymore

@fballiano fballiano merged commit 6a77e75 into OpenMage:1.9.4.x Sep 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 6a77e75. ± Comparison against base commit 926e005.

@elidrissidev elidrissidev deleted the refactor/error-reporting-constants-polyfill branch September 5, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Relates to Mage_Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants