Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpstan: fixed calls on Varien_Object/Mage_Core_Model_Abstract #2565

Merged
merged 5 commits into from
Sep 7, 2022
Merged

phpstan: fixed calls on Varien_Object/Mage_Core_Model_Abstract #2565

merged 5 commits into from
Sep 7, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Sep 6, 2022

Description (*)

Fixed some phpstan errors ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogInventory Relates to Mage_CatalogInventory Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Install Relates to Mage_Install Component: PayPal Relates to Mage_Paypal Component: Sales Relates to Mage_Sales Component: Shipping Relates to Mage_Shipping Component: Tax Relates to Mage_Tax Component: Wishlist Relates to Mage_Wishlist environment phpstan labels Sep 6, 2022
@sreichel sreichel changed the title Phpstan/daily phpstan: fixed calls on Varien_Object/Mage_Core_Model_Absract Sep 6, 2022
fballiano
fballiano previously approved these changes Sep 6, 2022
View reviewed changes
@sreichel sreichel changed the title phpstan: fixed calls on Varien_Object/Mage_Core_Model_Absract phpstan: fixed calls on Varien_Object/Mage_Core_Model_Abstract Sep 7, 2022
@fballiano fballiano merged commit 116c5f6 into OpenMage:1.9.4.x Sep 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 116c5f6. ± Comparison against base commit 77cfd17.

@sreichel sreichel deleted the phpstan/daily branch September 7, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiatng kiatng kiatng approved these changes

@fballiano fballiano fballiano approved these changes

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogInventory Relates to Mage_CatalogInventory Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Install Relates to Mage_Install Component: PayPal Relates to Mage_Paypal Component: Sales Relates to Mage_Sales Component: Shipping Relates to Mage_Shipping Component: Tax Relates to Mage_Tax Component: Wishlist Relates to Mage_Wishlist environment phpstan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @fballiano @kiatng