Update label for system/csrf/use_form_key config
#2578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreichel
approved these changes
Sep 8, 2022
Sdfendor
approved these changes
Sep 9, 2022
fballiano
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This PR updates the label for
system/csrf/use_form_keyconfig, it always confuses me because it says "Add Secret Key to URL" which is not true. I guess the whole xml node was copied fromadmin/security/use_form_keyand the label was never updated. This update should not break the translation because "Enabled" already exists.Manual testing scenarios (*)
Contribution checklist (*)