Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Mage_AmazonPayments.csv #2579

Merged

Conversation

elidrissidev
Copy link
Member

@elidrissidev elidrissidev commented Sep 8, 2022

Description (*)

This file was just sitting there. I can't find any references to it in the code, so off it goes.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the translations Relates to app/locale label Sep 8, 2022
@ADDISON74
Copy link
Contributor

I searched around 20 phrases in the code and I did not find any reference. We are dealing with an orphan translation file.

@fballiano fballiano merged commit ef1b965 into OpenMage:1.9.4.x Sep 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit ef1b965. ± Comparison against base commit 5974333.

@elidrissidev elidrissidev deleted the delete-amazonpayments-translations branch September 8, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translations Relates to app/locale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants