Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2658 #2662

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Fixes #2658 #2662

merged 1 commit into from
Oct 20, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Oct 19, 2022 •
edited
Loading

Description (*)

#2603 was for filter disabled products in admin backend / create orders. Some changes have inpact on frontend and should be reverted.

Related Pull Requests

  1. Fixes Fixed Mage_Catalog_Model_Product_Status::addSaleableFilterToCollection() does nothing #2603

Fixed Issues (if relevant)

  1. Fixes Product flat tables broken, ref #2603 #2658
  2. Closes Avoid filtering on product status if flat catalog is enabled #2659
  3. Closes Rewrote the $select->setPart() usage because it looses the "where type" #2660

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: Catalog Relates to Mage_Catalog label Oct 19, 2022
@sreichel sreichel changed the title Fixes #2603 Fixes #2658 Oct 19, 2022
@sreichel
Copy link
Contributor Author

@fballiano please let revert this.

If there is a good reason to change current behavior we should discuss this separately. ATM I just want to fix this issue. Revert your change does it.

@sreichel sreichel merged commit f251bbf into OpenMage:1.9.4.x Oct 20, 2022
@sreichel sreichel deleted the ¹hotfix/2603-1 branch October 20, 2022 19:43
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit f251bbf. ± Comparison against base commit 15f83af.

This was referenced Mar 2, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fballiano fballiano fballiano approved these changes

@ADDISON74 ADDISON74 ADDISON74 approved these changes

Assignees
No one assigned
Labels
Component: Catalog Relates to Mage_Catalog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Product flat tables broken, ref #2603
3 participants
@sreichel @fballiano @ADDISON74