Do not crash when shipment does not exist #2683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Adminhtml
sreichel
previously approved these changes
Nov 6, 2022
|
should we have the same redirect we have for #2684? |
|
Good observation. A small change is needed before approving this PR. |
kiatng
approved these changes
Nov 8, 2022
sreichel
approved these changes
Nov 8, 2022
addison74
approved these changes
Nov 8, 2022
elidrissidev
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Go to Sales / Shipment, open any shipment. In the URL, change the shipment id with an id that does not exist, you will got:
no date part in '' found.OpenMage 20.0.16 / PHP 8.0.25
Contribution checklist