Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes typo in join alias in indexer #2711

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

rubanooo
Copy link
Contributor

Description (*)

This fixes a type made in the join alias

Related Pull Requests

#2651

@github-actions github-actions bot added the Component: Catalog Relates to Mage_Catalog label Nov 16, 2022
Copy link
Contributor

@fballiano fballiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested!

actually I'm wondering how I made this typo in the first place, since I was trying this patch on a real store...

@elidrissidev
Copy link
Member

Apologies, I also missed it.

@elidrissidev elidrissidev merged commit 90ee030 into OpenMage:1.9.4.x Nov 16, 2022
@github-actions
Copy link
Contributor

Unit Test Results

1 files  1 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌
7 runs  5 ✔️ 2 💤 0 ❌

Results for commit 90ee030.

@rubanooo rubanooo deleted the fix-index-join branch November 16, 2022 10:48
@elidrissidev
Copy link
Member

@fballiano this may need a hotfix release soon depending on how critical it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Catalog Relates to Mage_Catalog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants