Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added confirmation before deleting website/store/storeview #2717

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Added confirmation before deleting website/store/storeview #2717

merged 1 commit into from
Nov 17, 2022

Conversation

fballiano
Copy link
Contributor

In the "manage stores" section of the backend it's possible to click the "deleting website/store/storeview" and delete without any confirmation being asked, which is very dangerous.

This PR adds the confirmation before actually delete website/store/storeview.

@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label Nov 16, 2022
@fballiano fballiano merged commit 7f75489 into OpenMage:1.9.4.x Nov 17, 2022
@fballiano fballiano deleted the delete_website branch November 17, 2022 00:20
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 7f75489. ± Comparison against base commit 028d842.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants